diff options
| author | Lanre Adelowo <adelowomailbox@gmail.com> | 2018-08-07 18:15:41 +0100 |
|---|---|---|
| committer | Lauris BH <lauris@nix.lv> | 2018-08-07 20:15:41 +0300 |
| commit | 0df7cab4fb0c84444ceb4c9b5f28f410a38025f5 (patch) | |
| tree | 4f5de68f3881caf4646e1a0d187a6ba7b2cebcf7 /modules/auth/repo_form.go | |
| parent | 59b10e66f757441e8c74532f30740bf4a96e9ac1 (diff) | |
| download | gitea-0df7cab4fb0c84444ceb4c9b5f28f410a38025f5.tar.gz gitea-0df7cab4fb0c84444ceb4c9b5f28f410a38025f5.zip | |
prevent empty review comment (#4632)
* prevent empty review comment
This would only require a comment for rejection and comment
* add tests
* add comment
Diffstat (limited to 'modules/auth/repo_form.go')
| -rw-r--r-- | modules/auth/repo_form.go | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/modules/auth/repo_form.go b/modules/auth/repo_form.go index d205a6fd53..3c7940afce 100644 --- a/modules/auth/repo_form.go +++ b/modules/auth/repo_form.go @@ -402,6 +402,14 @@ func (f SubmitReviewForm) ReviewType() models.ReviewType { } } +// HasEmptyContent checks if the content of the review form is empty. +func (f SubmitReviewForm) HasEmptyContent() bool { + reviewType := f.ReviewType() + + return (reviewType == models.ReviewTypeComment || reviewType == models.ReviewTypeReject) && + len(strings.TrimSpace(f.Content)) == 0 +} + // __________ .__ // \______ \ ____ | | ____ _____ ______ ____ // | _// __ \| | _/ __ \\__ \ / ___// __ \ |