summaryrefslogtreecommitdiffstats
path: root/modules/base
diff options
context:
space:
mode:
authorEthan Koenig <ethantkoenig@gmail.com>2017-06-29 10:30:58 -0400
committerEthan Koenig <ethantkoenig@gmail.com>2017-06-29 10:37:55 -0400
commit23f072887935a6aa81634ef487432ff2b5fa250a (patch)
treeaaaaa6a1be49c3c623103433e3ba5982b0b1f5bb /modules/base
parent33f3165296613c819ed82612da2f6738c1301ec1 (diff)
downloadgitea-23f072887935a6aa81634ef487432ff2b5fa250a.tar.gz
gitea-23f072887935a6aa81634ef487432ff2b5fa250a.zip
Don't ignore gravatar error
Diffstat (limited to 'modules/base')
-rw-r--r--modules/base/tool.go6
1 files changed, 4 insertions, 2 deletions
diff --git a/modules/base/tool.go b/modules/base/tool.go
index 8952e7a8c9..0f730868eb 100644
--- a/modules/base/tool.go
+++ b/modules/base/tool.go
@@ -197,8 +197,10 @@ func HashEmail(email string) string {
// to return full URL if user enables Gravatar-like service.
func AvatarLink(email string) string {
if setting.EnableFederatedAvatar && setting.LibravatarService != nil {
- // TODO: This doesn't check any error. AvatarLink should return (string, error)
- url, _ := setting.LibravatarService.FromEmail(email)
+ url, err := setting.LibravatarService.FromEmail(email)
+ if err != nil {
+ log.Error(4, "LibravatarService.FromEmail(email=%s): error %v", email, err)
+ }
return url
}