diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2021-10-20 22:37:19 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-20 16:37:19 +0200 |
| commit | f494776931b71f83fdfdd4e68e850529c4b2614f (patch) | |
| tree | 92b3779237dadfe042d3f93e9ddaaaac5d6d385f /modules/context | |
| parent | 0208ea0248782a994771cadf0af6a4125fdde723 (diff) | |
| download | gitea-f494776931b71f83fdfdd4e68e850529c4b2614f.tar.gz gitea-f494776931b71f83fdfdd4e68e850529c4b2614f.zip | |
Use a variable but a function for IsProd because of a slight performance increment (#17368)
Diffstat (limited to 'modules/context')
| -rw-r--r-- | modules/context/api.go | 4 | ||||
| -rw-r--r-- | modules/context/context.go | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/modules/context/api.go b/modules/context/api.go index e5216d911f..c978835af8 100644 --- a/modules/context/api.go +++ b/modules/context/api.go @@ -95,7 +95,7 @@ func (ctx *APIContext) Error(status int, title string, obj interface{}) { if status == http.StatusInternalServerError { log.ErrorWithSkip(1, "%s: %s", title, message) - if setting.IsProd() && !(ctx.User != nil && ctx.User.IsAdmin) { + if setting.IsProd && !(ctx.User != nil && ctx.User.IsAdmin) { message = "" } } @@ -112,7 +112,7 @@ func (ctx *APIContext) InternalServerError(err error) { log.ErrorWithSkip(1, "InternalServerError: %v", err) var message string - if !setting.IsProd() || (ctx.User != nil && ctx.User.IsAdmin) { + if !setting.IsProd || (ctx.User != nil && ctx.User.IsAdmin) { message = err.Error() } diff --git a/modules/context/context.go b/modules/context/context.go index 0a603cced5..383a69ad63 100644 --- a/modules/context/context.go +++ b/modules/context/context.go @@ -225,7 +225,7 @@ func (ctx *Context) NotFound(title string, err error) { func (ctx *Context) notFoundInternal(title string, err error) { if err != nil { log.ErrorWithSkip(2, "%s: %v", title, err) - if !setting.IsProd() { + if !setting.IsProd { ctx.Data["ErrorMsg"] = err } } @@ -261,7 +261,7 @@ func (ctx *Context) ServerError(title string, err error) { func (ctx *Context) serverErrorInternal(title string, err error) { if err != nil { log.ErrorWithSkip(2, "%s: %v", title, err) - if !setting.IsProd() { + if !setting.IsProd { ctx.Data["ErrorMsg"] = err } } @@ -645,7 +645,7 @@ func Contexter() func(next http.Handler) http.Handler { "CurrentURL": setting.AppSubURL + req.URL.RequestURI(), "PageStartTime": startTime, "Link": link, - "IsProd": setting.IsProd(), + "IsProd": setting.IsProd, }, } // PageData is passed by reference, and it will be rendered to `window.config.pageData` in `head.tmpl` for JavaScript modules |