diff options
| author | zeripath <art27@cantab.net> | 2021-12-24 16:50:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-25 00:50:49 +0800 |
| commit | 16adaaeaa3d6ebe19e203e5626120ed1cd4fea6c (patch) | |
| tree | 7a95791e32336c53bfe75544b5dac4e6b31cc800 /modules/context | |
| parent | 26070eb818a09e7123c178434e73c9def88ea8e7 (diff) | |
| download | gitea-16adaaeaa3d6ebe19e203e5626120ed1cd4fea6c.tar.gz gitea-16adaaeaa3d6ebe19e203e5626120ed1cd4fea6c.zip | |
Instead of using routerCtx just escape the url before routing (#18086)
A consequence of forcibly setting the RoutePath to the escaped url is that the
auto routing to endpoints without terminal slashes fails (Causing #18060.) This
failure raises the possibility that forcibly setting the RoutePath causes other
unexpected behaviors too.
Therefore, instead we should simply pre-escape the URL in the process registering
handler. Then the request URL will be properly escaped for all the following calls.
Fix #17938
Fix #18060
Replace #18062
Replace #17997
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'modules/context')
| -rw-r--r-- | modules/context/context.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/modules/context/context.go b/modules/context/context.go index 94e1f6cfff..5038850649 100644 --- a/modules/context/context.go +++ b/modules/context/context.go @@ -610,9 +610,6 @@ func Contexter() func(next http.Handler) http.Handler { var startTime = time.Now() var link = setting.AppSubURL + strings.TrimSuffix(req.URL.EscapedPath(), "/") - chiCtx := chi.RouteContext(req.Context()) - chiCtx.RoutePath = req.URL.EscapedPath() - var ctx = Context{ Resp: NewResponse(resp), Cache: mc.GetCache(), |