diff options
| author | zeripath <art27@cantab.net> | 2019-08-05 21:39:39 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-08-05 21:39:39 +0100 |
| commit | 7ad67109d732bd560c8da0356aa555be467d786c (patch) | |
| tree | 7c7a35761b01e2eec6a823f0caf40748c3b7f327 /modules/git/commit.go | |
| parent | 1d8915ad5d9889c02dd98ab2c2f29aa8f5ee4dfa (diff) | |
| download | gitea-7ad67109d732bd560c8da0356aa555be467d786c.tar.gz gitea-7ad67109d732bd560c8da0356aa555be467d786c.zip | |
Be more strict with git arguments (#7715)
* Be more strict with git arguments
* fix-up commit test
* use bindings for branch name
Diffstat (limited to 'modules/git/commit.go')
| -rw-r--r-- | modules/git/commit.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/modules/git/commit.go b/modules/git/commit.go index c86ece9848..2f7f53e7ce 100644 --- a/modules/git/commit.go +++ b/modules/git/commit.go @@ -169,6 +169,7 @@ func AddChanges(repoPath string, all bool, files ...string) error { if all { cmd.AddArguments("--all") } + cmd.AddArguments("--") _, err := cmd.AddArguments(files...).RunInDir(repoPath) return err } @@ -304,6 +305,7 @@ func (c *Commit) GetFilesChangedSinceCommit(pastCommit string) ([]string, error) } // FileChangedSinceCommit Returns true if the file given has changed since the the past commit +// YOU MUST ENSURE THAT pastCommit is a valid commit ID. func (c *Commit) FileChangedSinceCommit(filename, pastCommit string) (bool, error) { return c.repo.FileChangedBetweenCommits(filename, pastCommit, c.ID.String()) } |