diff options
| author | zeripath <art27@cantab.net> | 2022-11-13 22:43:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-13 22:43:40 +0000 |
| commit | 9dc53ba65f3a6b87acdd34d65dc4704cb3cf9e43 (patch) | |
| tree | a4ea82b65a740005cb7d66b1505f37e7fb953b3b /modules/git/git.go | |
| parent | d25c74f3536909ef526b1dbf6a2eff328de83fab (diff) | |
| download | gitea-9dc53ba65f3a6b87acdd34d65dc4704cb3cf9e43.tar.gz gitea-9dc53ba65f3a6b87acdd34d65dc4704cb3cf9e43.zip | |
Prevent panic in doctor command when running default checks (#21791) (#21808)
Backport #21791
There was a bug introduced in #21352 due to a change of behaviour caused
by #19280. This causes a panic on running the default doctor checks
because the panic introduced by #19280 assumes that the only way
opts.StdOut and opts.Stderr can be set in RunOpts is deliberately.
Unfortunately, when running a git.Command the provided RunOpts can be
set, therefore if you share a common set of RunOpts these two values can
be set by the previous commands.
This PR stops using common RunOpts for the commands in that doctor check
but secondly stops RunCommand variants from changing the provided
RunOpts.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'modules/git/git.go')
0 files changed, 0 insertions, 0 deletions