diff options
| author | KN4CK3R <admin@oldschoolhack.me> | 2021-08-09 20:08:51 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-09 14:08:51 -0400 |
| commit | d9ef43a7126ab83af563c1c9b54cdf0092327b2a (patch) | |
| tree | fabc9a9d24d42bb0de6dd9557c9e07e95bd5722b /modules/git/repo.go | |
| parent | 23d438f56524a7c3fc185df66d6d95f797a80eee (diff) | |
| download | gitea-d9ef43a7126ab83af563c1c9b54cdf0092327b2a.tar.gz gitea-d9ef43a7126ab83af563c1c9b54cdf0092327b2a.zip | |
Replace `list.List` with slices (#16311)
* Replaced list with slice.
* Fixed usage of pointer to temporary variable.
* Replaced LIFO list with slice.
* Lint
* Removed type check.
* Removed duplicated code.
* Lint
* Fixed merge.
Co-authored-by: 6543 <6543@obermui.de>
Diffstat (limited to 'modules/git/repo.go')
| -rw-r--r-- | modules/git/repo.go | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/modules/git/repo.go b/modules/git/repo.go index 43f329f448..4e6f90c3ef 100644 --- a/modules/git/repo.go +++ b/modules/git/repo.go @@ -7,7 +7,6 @@ package git import ( "bytes" - "container/list" "context" "fmt" "os" @@ -33,10 +32,10 @@ func (repo *Repository) GetAllCommitsCount() (int64, error) { return AllCommitsCount(repo.Path, false) } -func (repo *Repository) parsePrettyFormatLogToList(logs []byte) (*list.List, error) { - l := list.New() +func (repo *Repository) parsePrettyFormatLogToList(logs []byte) ([]*Commit, error) { + var commits []*Commit if len(logs) == 0 { - return l, nil + return commits, nil } parts := bytes.Split(logs, []byte{'\n'}) @@ -46,10 +45,10 @@ func (repo *Repository) parsePrettyFormatLogToList(logs []byte) (*list.List, err if err != nil { return nil, err } - l.PushBack(commit) + commits = append(commits, commit) } - return l, nil + return commits, nil } // IsRepoURLAccessible checks if given repository URL is accessible. |