diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2022-06-10 09:57:49 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-10 09:57:49 +0800 |
| commit | a0051634b982608d94399033a8b76e7e3b1537ac (patch) | |
| tree | 174bf860eb23c80bff16dc0e94f8d7d1a3437f0a /modules/git/repo_attribute.go | |
| parent | e26f84a9b75f250f951e0efa5c5c62860b3c8370 (diff) | |
| download | gitea-a0051634b982608d94399033a8b76e7e3b1537ac.tar.gz gitea-a0051634b982608d94399033a8b76e7e3b1537ac.zip | |
Refactor git module, make Gitea use internal git config (#19732)
* Refactor git module, make Gitea use internal git config, add safe.directory config
* introduce git.InitSimple and git.InitWithConfigSync, make serv cmd use gitconfig
* use HOME instead of GIT_CONFIG_GLOBAL, because git always needs a correct HOME
* fix cmd env in cmd/serv.go
* fine tune error message
* Fix a incorrect test case
* fix configAddNonExist
* fix configAddNonExist logic, add `--fixed-value` flag, add tests
* add configSetNonExist function in case it's needed.
* use configSetNonExist for `user.name` and `user.email`
* add some comments
* Update cmd/serv.go
Co-authored-by: zeripath <art27@cantab.net>
* Update cmd/serv.go
Co-authored-by: zeripath <art27@cantab.net>
* Update modules/git/git.go
Co-authored-by: zeripath <art27@cantab.net>
* Update modules/setting/setting.go
Co-authored-by: zeripath <art27@cantab.net>
* Update modules/git/repo_attribute.go
Co-authored-by: zeripath <art27@cantab.net>
* fix spaces in messages
* use `configSet("core.protectNTFS", ...)` instead of `globalCommandArgs`
* remove GIT_CONFIG_NOSYSTEM, continue to use system's git config
* Update cmd/serv.go
Co-authored-by: zeripath <art27@cantab.net>
* fix merge
* remove code for safe.directory
* separate git.CommonEnvs to CommonGitCmdEnvs and CommonCmdServEnvs
* avoid Golang's data race error
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'modules/git/repo_attribute.go')
| -rw-r--r-- | modules/git/repo_attribute.go | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/modules/git/repo_attribute.go b/modules/git/repo_attribute.go index a18c80c3f1..38818788f3 100644 --- a/modules/git/repo_attribute.go +++ b/modules/git/repo_attribute.go @@ -28,11 +28,6 @@ type CheckAttributeOpts struct { // CheckAttribute return the Blame object of file func (repo *Repository) CheckAttribute(opts CheckAttributeOpts) (map[string]map[string]string, error) { - err := LoadGitVersion() - if err != nil { - return nil, fmt.Errorf("git version missing: %v", err) - } - env := []string{} if len(opts.IndexFile) > 0 && CheckGitVersionAtLeast("1.7.8") == nil { @@ -126,7 +121,7 @@ type CheckAttributeReader struct { cancel context.CancelFunc } -// Init initializes the cmd +// Init initializes the CheckAttributeReader func (c *CheckAttributeReader) Init(ctx context.Context) error { cmdArgs := []string{"check-attr", "--stdin", "-z"} |