diff options
| author | Nanguan Lin <70063547+lng2020@users.noreply.github.com> | 2023-10-11 19:02:24 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-11 11:02:24 +0000 |
| commit | dc04044716088e3786497e200abe1fdfb3a943b6 (patch) | |
| tree | 45230f2067cbf0f130042e33eed36a38ed69e9b1 /modules/git/repo_attribute_test.go | |
| parent | dca195e9bd0d14a5cf888524e51175da8ab24588 (diff) | |
| download | gitea-dc04044716088e3786497e200abe1fdfb3a943b6.tar.gz gitea-dc04044716088e3786497e200abe1fdfb3a943b6.zip | |
Replace assert.Fail with assert.FailNow (#27578)
assert.Fail() will continue to execute the code while assert.FailNow()
not. I thought those uses of assert.Fail() should exit immediately.
PS: perhaps it's a good idea to use
[require](https://pkg.go.dev/github.com/stretchr/testify/require)
somewhere because the assert package's default behavior does not exit
when an error occurs, which makes it difficult to find the root error
reason.
Diffstat (limited to 'modules/git/repo_attribute_test.go')
| -rw-r--r-- | modules/git/repo_attribute_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/modules/git/repo_attribute_test.go b/modules/git/repo_attribute_test.go index 350b69dd25..ed16dccbe4 100644 --- a/modules/git/repo_attribute_test.go +++ b/modules/git/repo_attribute_test.go @@ -27,7 +27,7 @@ func Test_nulSeparatedAttributeWriter_ReadAttribute(t *testing.T) { assert.Equal(t, "linguist-vendored", attr.Attribute) assert.Equal(t, "unspecified", attr.Value) case <-time.After(100 * time.Millisecond): - assert.Fail(t, "took too long to read an attribute from the list") + assert.FailNow(t, "took too long to read an attribute from the list") } // Write a second attribute again n, err = wr.Write([]byte(testStr)) @@ -41,7 +41,7 @@ func Test_nulSeparatedAttributeWriter_ReadAttribute(t *testing.T) { assert.Equal(t, "linguist-vendored", attr.Attribute) assert.Equal(t, "unspecified", attr.Value) case <-time.After(100 * time.Millisecond): - assert.Fail(t, "took too long to read an attribute from the list") + assert.FailNow(t, "took too long to read an attribute from the list") } // Write a partial attribute @@ -52,14 +52,14 @@ func Test_nulSeparatedAttributeWriter_ReadAttribute(t *testing.T) { select { case <-wr.ReadAttribute(): - assert.Fail(t, "There should not be an attribute ready to read") + assert.FailNow(t, "There should not be an attribute ready to read") case <-time.After(100 * time.Millisecond): } _, err = wr.Write([]byte("attribute\x00")) assert.NoError(t, err) select { case <-wr.ReadAttribute(): - assert.Fail(t, "There should not be an attribute ready to read") + assert.FailNow(t, "There should not be an attribute ready to read") case <-time.After(100 * time.Millisecond): } |