diff options
| author | zeripath <art27@cantab.net> | 2021-12-08 19:08:16 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-08 19:08:16 +0000 |
| commit | 9e6e1dc950f06bbd000d5b6438f39113e8902082 (patch) | |
| tree | 204f359885c2bda09603de7de90b93f61c8e6922 /modules/git/repo_branch_test.go | |
| parent | b59875aa123f2cc3a5026d30ac557e99c05603a6 (diff) | |
| download | gitea-9e6e1dc950f06bbd000d5b6438f39113e8902082.tar.gz gitea-9e6e1dc950f06bbd000d5b6438f39113e8902082.zip | |
Improve checkBranchName (#17901)
The current implementation of checkBranchName is highly inefficient
involving opening the repository, the listing all of the branch names
checking them individually before then using using opened repo to get
the tags.
This PR avoids this by simply walking the references from show-ref
instead of opening the repository (in the nogogit case).
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'modules/git/repo_branch_test.go')
| -rw-r--r-- | modules/git/repo_branch_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/modules/git/repo_branch_test.go b/modules/git/repo_branch_test.go index 05d5237e6a..ac5f5deea9 100644 --- a/modules/git/repo_branch_test.go +++ b/modules/git/repo_branch_test.go @@ -17,21 +17,21 @@ func TestRepository_GetBranches(t *testing.T) { assert.NoError(t, err) defer bareRepo1.Close() - branches, countAll, err := bareRepo1.GetBranches(0, 2) + branches, countAll, err := bareRepo1.GetBranchNames(0, 2) assert.NoError(t, err) assert.Len(t, branches, 2) assert.EqualValues(t, 3, countAll) assert.ElementsMatch(t, []string{"branch1", "branch2"}, branches) - branches, countAll, err = bareRepo1.GetBranches(0, 0) + branches, countAll, err = bareRepo1.GetBranchNames(0, 0) assert.NoError(t, err) assert.Len(t, branches, 3) assert.EqualValues(t, 3, countAll) assert.ElementsMatch(t, []string{"branch1", "branch2", "master"}, branches) - branches, countAll, err = bareRepo1.GetBranches(5, 1) + branches, countAll, err = bareRepo1.GetBranchNames(5, 1) assert.NoError(t, err) assert.Len(t, branches, 0) @@ -48,7 +48,7 @@ func BenchmarkRepository_GetBranches(b *testing.B) { defer bareRepo1.Close() for i := 0; i < b.N; i++ { - _, _, err := bareRepo1.GetBranches(0, 0) + _, _, err := bareRepo1.GetBranchNames(0, 0) if err != nil { b.Fatal(err) } |