diff options
| author | silverwind <me@silverwind.io> | 2023-03-02 06:32:21 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-02 13:32:21 +0800 |
| commit | ea1d09718ce2e3bf043c60bae76dd6bd7e84e9fe (patch) | |
| tree | 55b34ddb05ff009f8bce92aca46da8ef0919b574 /modules/git/repo_commit_nogogit.go | |
| parent | 0945bf63d3e0784c06a9d85504d42458b091d6b8 (diff) | |
| download | gitea-ea1d09718ce2e3bf043c60bae76dd6bd7e84e9fe.tar.gz gitea-ea1d09718ce2e3bf043c60bae76dd6bd7e84e9fe.zip | |
Fix commit retrieval by tag (#21804)
It is not correct to return tag data when commit data is requested, so
remove the hacky code that overwrote parts of a commit with parts of a
tag.
This fixes commit retrieval by tag for both the latest commit in the UI
and the commit info on tag webhook events.
Fixes: https://github.com/go-gitea/gitea/issues/21687
Replaces: https://github.com/go-gitea/gitea/pull/21693
<img width="324" alt="Screenshot 2022-11-13 at 15 26 37"
src="https://user-images.githubusercontent.com/115237/201526975-736c6ea7-ad6a-467a-a823-9a63d6ecb718.png">
<img width="789" alt="image"
src="https://user-images.githubusercontent.com/115237/201526876-90a13ffc-1e5c-4d76-911b-f1ae51e8eaab.png">
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'modules/git/repo_commit_nogogit.go')
| -rw-r--r-- | modules/git/repo_commit_nogogit.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/modules/git/repo_commit_nogogit.go b/modules/git/repo_commit_nogogit.go index 7373d01c8e..d5eb723100 100644 --- a/modules/git/repo_commit_nogogit.go +++ b/modules/git/repo_commit_nogogit.go @@ -107,10 +107,6 @@ func (repo *Repository) getCommitFromBatchReader(rd *bufio.Reader, id SHA1) (*Co return nil, err } - commit.CommitMessage = strings.TrimSpace(tag.Message) - commit.Author = tag.Tagger - commit.Signature = tag.Signature - return commit, nil case "commit": commit, err := CommitFromReader(repo, id, io.LimitReader(rd, size)) |