summaryrefslogtreecommitdiffstats
path: root/modules/git
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2021-02-07 21:04:58 +0000
committerGitHub <noreply@github.com>2021-02-07 21:04:58 +0000
commite65cfabda7caa22eef92137c5c501d1c60fcc42a (patch)
treeaa3fac152e35fc017fbcac34b873162cebed6df8 /modules/git
parent5f248d0df290fd08ed54e31424cbb8d8517229e3 (diff)
downloadgitea-e65cfabda7caa22eef92137c5c501d1c60fcc42a.tar.gz
gitea-e65cfabda7caa22eef92137c5c501d1c60fcc42a.zip
Remove spurious DataAsync Error logging (#14599)
Breaking the pipe is a valid way of killing a piped command and any error from a broken cat-file batch command should be passed back up to the writer any way therefore specifically logging it is unnecessary. Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'modules/git')
-rw-r--r--modules/git/blob_nogogit.go3
1 files changed, 0 insertions, 3 deletions
diff --git a/modules/git/blob_nogogit.go b/modules/git/blob_nogogit.go
index 731f7d06e8..e917a31619 100644
--- a/modules/git/blob_nogogit.go
+++ b/modules/git/blob_nogogit.go
@@ -11,8 +11,6 @@ import (
"io"
"strconv"
"strings"
-
- gitea_log "code.gitea.io/gitea/modules/log"
)
// Blob represents a Git object.
@@ -35,7 +33,6 @@ func (b *Blob) DataAsync() (io.ReadCloser, error) {
err := NewCommand("cat-file", "--batch").RunInDirFullPipeline(b.repoPath, stdoutWriter, stderr, strings.NewReader(b.ID.String()+"\n"))
if err != nil {
err = ConcatenateError(err, stderr.String())
- gitea_log.Error("Blob.DataAsync Error: %v", err)
_ = stdoutWriter.CloseWithError(err)
} else {
_ = stdoutWriter.Close()