summaryrefslogtreecommitdiffstats
path: root/modules/graceful
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2021-05-07 10:27:31 +0100
committerGitHub <noreply@github.com>2021-05-07 11:27:31 +0200
commitbdc169772980285a89480a93c78731b6f45ee2ff (patch)
treefaa3de08e9d126d800c61e9a796a39251f866a31 /modules/graceful
parent640066840e23367d9d13e92d786b877448ae9329 (diff)
downloadgitea-bdc169772980285a89480a93c78731b6f45ee2ff.tar.gz
gitea-bdc169772980285a89480a93c78731b6f45ee2ff.zip
Drop back to use IsAnInteractiveSession for SVC (#15749)
* Drop back to use IsAnInteractiveSession for SVC There is an apparent permission change problem when using IsWindowsService to determine if the SVC manager should be used. This PR simply drops back to using IsAnInteractiveSession as this does not change behaviour. Fix #15454 Signed-off-by: Andrew Thornton <art27@cantab.net> * Yes staticcheck I know this is deprecated Signed-off-by: Andrew Thornton <art27@cantab.net> * Just leave me alone lint Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
Diffstat (limited to 'modules/graceful')
-rw-r--r--modules/graceful/manager_windows.go6
1 files changed, 4 insertions, 2 deletions
diff --git a/modules/graceful/manager_windows.go b/modules/graceful/manager_windows.go
index b0e0d1ce38..14923c2a9b 100644
--- a/modules/graceful/manager_windows.go
+++ b/modules/graceful/manager_windows.go
@@ -74,12 +74,14 @@ func (g *Manager) start() {
// Make SVC process
run := svc.Run
- isWindowsService, err := svc.IsWindowsService()
+
+ //lint:ignore SA1019 We use IsAnInteractiveSession because IsWindowsService has a different permissions profile
+ isAnInteractiveSession, err := svc.IsAnInteractiveSession()
if err != nil {
log.Error("Unable to ascertain if running as an Windows Service: %v", err)
return
}
- if !isWindowsService {
+ if isAnInteractiveSession {
log.Trace("Not running a service ... using the debug SVC manager")
run = debug.Run
}