summaryrefslogtreecommitdiffstats
path: root/modules/highlight/highlight_test.go
diff options
context:
space:
mode:
authorsilverwind <me@silverwind.io>2022-11-19 12:08:06 +0100
committerGitHub <noreply@github.com>2022-11-19 13:08:06 +0200
commiteec1c718806797b21ba5f6c1ceddf711e9d4801a (patch)
tree646d71d535db4b00a09916b1d321e01536799f6f /modules/highlight/highlight_test.go
parent044c754ea53f5b81f451451df53aea366f6f700a (diff)
downloadgitea-eec1c718806797b21ba5f6c1ceddf711e9d4801a.tar.gz
gitea-eec1c718806797b21ba5f6c1ceddf711e9d4801a.zip
Show syntax lexer name in file view/blame (#21814)
Show which Chroma Lexer is used to highlight the file in the file header. It's useful for development to see what was detected, and I think it's not bad info to have for the user: <img width="233" alt="Screenshot 2022-11-14 at 22 31 16" src="https://user-images.githubusercontent.com/115237/201770854-44933dfc-70a4-487c-8457-1bb3cc43ea62.png"> <img width="226" alt="Screenshot 2022-11-14 at 22 36 06" src="https://user-images.githubusercontent.com/115237/201770856-9260ce6f-6c0f-442c-92b5-201e5b113188.png"> <img width="194" alt="Screenshot 2022-11-14 at 22 36 26" src="https://user-images.githubusercontent.com/115237/201770857-6f56591b-80ea-42cc-8ea5-21b9156c018b.png"> Also, I improved the way this header overflows on small screens: <img width="354" alt="Screenshot 2022-11-14 at 22 44 36" src="https://user-images.githubusercontent.com/115237/201774828-2ddbcde1-da15-403f-bf7a-6248449fa2c5.png"> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Diffstat (limited to 'modules/highlight/highlight_test.go')
-rw-r--r--modules/highlight/highlight_test.go59
1 files changed, 40 insertions, 19 deletions
diff --git a/modules/highlight/highlight_test.go b/modules/highlight/highlight_test.go
index 8f83f4a2f6..1899753746 100644
--- a/modules/highlight/highlight_test.go
+++ b/modules/highlight/highlight_test.go
@@ -17,34 +17,52 @@ func lines(s string) []string {
func TestFile(t *testing.T) {
tests := []struct {
- name string
- code string
- want []string
+ name string
+ code string
+ want []string
+ lexerName string
}{
{
- name: "empty.py",
- code: "",
- want: lines(""),
+ name: "empty.py",
+ code: "",
+ want: lines(""),
+ lexerName: "Python",
},
{
- name: "tags.txt",
- code: "<>",
- want: lines("&lt;&gt;"),
+ name: "empty.js",
+ code: "",
+ want: lines(""),
+ lexerName: "JavaScript",
},
{
- name: "tags.py",
- code: "<>",
- want: lines(`<span class="o">&lt;</span><span class="o">&gt;</span>`),
+ name: "empty.yaml",
+ code: "",
+ want: lines(""),
+ lexerName: "YAML",
},
{
- name: "eol-no.py",
- code: "a=1",
- want: lines(`<span class="n">a</span><span class="o">=</span><span class="mi">1</span>`),
+ name: "tags.txt",
+ code: "<>",
+ want: lines("&lt;&gt;"),
+ lexerName: "Plaintext",
},
{
- name: "eol-newline1.py",
- code: "a=1\n",
- want: lines(`<span class="n">a</span><span class="o">=</span><span class="mi">1</span>\n`),
+ name: "tags.py",
+ code: "<>",
+ want: lines(`<span class="o">&lt;</span><span class="o">&gt;</span>`),
+ lexerName: "Python",
+ },
+ {
+ name: "eol-no.py",
+ code: "a=1",
+ want: lines(`<span class="n">a</span><span class="o">=</span><span class="mi">1</span>`),
+ lexerName: "Python",
+ },
+ {
+ name: "eol-newline1.py",
+ code: "a=1\n",
+ want: lines(`<span class="n">a</span><span class="o">=</span><span class="mi">1</span>\n`),
+ lexerName: "Python",
},
{
name: "eol-newline2.py",
@@ -54,6 +72,7 @@ func TestFile(t *testing.T) {
\n
`,
),
+ lexerName: "Python",
},
{
name: "empty-line-with-space.py",
@@ -73,17 +92,19 @@ c=2
\n
<span class="n">c</span><span class="o">=</span><span class="mi">2</span>`,
),
+ lexerName: "Python",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- out, err := File(tt.name, "", []byte(tt.code))
+ out, lexerName, err := File(tt.name, "", []byte(tt.code))
assert.NoError(t, err)
expected := strings.Join(tt.want, "\n")
actual := strings.Join(out, "\n")
assert.Equal(t, strings.Count(actual, "<span"), strings.Count(actual, "</span>"))
assert.EqualValues(t, expected, actual)
+ assert.Equal(t, tt.lexerName, lexerName)
})
}
}