diff options
| author | Kemal Zebari <60799661+kemzeb@users.noreply.github.com> | 2024-04-23 00:10:01 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-23 15:10:01 +0800 |
| commit | 9b7af4340c36d3e1888788499d16f83feeb1601b (patch) | |
| tree | afcd8aea890d68f17c715df8d2bf9cb16b7f40cb /modules/indexer | |
| parent | 370b1bdb3757e91c59303b0ce6ec49c56eca795b (diff) | |
| download | gitea-9b7af4340c36d3e1888788499d16f83feeb1601b.tar.gz gitea-9b7af4340c36d3e1888788499d16f83feeb1601b.zip | |
Perform Newest sort type correctly when sorting issues (#30644)
Should resolve #30642.
Before this commit, we were treating an empty `?sort=` query parameter
as the correct sorting type (which is to sort issues in descending order
by their created UNIX time). But when we perform `sort=latest`, we did
not include this as a type so we would sort by the most recently updated
when reaching the `default` switch statement block.
This commit fixes this by considering the empty string, "latest", and
just any other string that is not mentioned in the switch statement as
sorting by newest.
Diffstat (limited to 'modules/indexer')
| -rw-r--r-- | modules/indexer/issues/dboptions.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/indexer/issues/dboptions.go b/modules/indexer/issues/dboptions.go index 4a98b4588a..8f94088742 100644 --- a/modules/indexer/issues/dboptions.go +++ b/modules/indexer/issues/dboptions.go @@ -68,7 +68,7 @@ func ToSearchOptions(keyword string, opts *issues_model.IssuesOptions) *SearchOp searchOpt.Paginator = opts.Paginator switch opts.SortType { - case "": + case "", "latest": searchOpt.SortBy = SortByCreatedDesc case "oldest": searchOpt.SortBy = SortByCreatedAsc @@ -86,7 +86,7 @@ func ToSearchOptions(keyword string, opts *issues_model.IssuesOptions) *SearchOp searchOpt.SortBy = SortByDeadlineDesc case "priority", "priorityrepo", "project-column-sorting": // Unsupported sort type for search - searchOpt.SortBy = SortByUpdatedDesc + fallthrough default: searchOpt.SortBy = SortByUpdatedDesc } |