diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-06-28 14:02:06 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-28 08:02:06 +0200 |
| commit | 65d3e1161b0544f50d94dbbecb6bcf135535e112 (patch) | |
| tree | 2f1a9a0630e37c9db17b842122b425b46b501867 /modules/log/manager_test.go | |
| parent | b943318617633e7dc43f3ac1c146be1e37563093 (diff) | |
| download | gitea-65d3e1161b0544f50d94dbbecb6bcf135535e112.tar.gz gitea-65d3e1161b0544f50d94dbbecb6bcf135535e112.zip | |
Fix sub-command log level (#25537)
More fix for #24981
* #24981
Close #22361
* #22361
There were many patches for Gitea's sub-commands to satisfy the facts:
* Some sub-commands shouldn't output any log, otherwise the git protocol
would be broken
* Sometimes the users want to see "verbose" or "quiet" outputs
That's a longstanding problem, and very fragile. This PR is only a quick
patch for the problem.
In the future, the sub-command system should be refactored to a clear
solution.
----
Other changes:
* Use `ReplaceAllWriters` to replace
`RemoveAllWriters().AddWriters(writer)`, then it's an atomic operation.
* Remove unnecessary `syncLevelInternal` calls, because
`AddWriters/addWritersInternal` already calls it.
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'modules/log/manager_test.go')
| -rw-r--r-- | modules/log/manager_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/log/manager_test.go b/modules/log/manager_test.go index aa01f79980..b8fbf84613 100644 --- a/modules/log/manager_test.go +++ b/modules/log/manager_test.go @@ -23,7 +23,7 @@ func TestSharedWorker(t *testing.T) { loggerTest := m.GetLogger("test") loggerTest.AddWriters(w) loggerTest.Info("msg-1") - loggerTest.RemoveAllWriters() // the shared writer is not closed here + loggerTest.ReplaceAllWriters() // the shared writer is not closed here loggerTest.Info("never seen") // the shared writer can still be used later |