diff options
author | zeripath <art27@cantab.net> | 2022-06-03 15:36:18 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-06-03 15:36:18 +0100 |
commit | 1d04e8641d4abab6ce978bc2dc5523c2ddb2f628 (patch) | |
tree | 742564159535d13dd060074187be79616da2bb3f /modules/markup/external/external.go | |
parent | 085924b1b370310c989fa5e75bb33323746382b0 (diff) | |
download | gitea-1d04e8641d4abab6ce978bc2dc5523c2ddb2f628.tar.gz gitea-1d04e8641d4abab6ce978bc2dc5523c2ddb2f628.zip |
Set Setpgid on child git processes (#19865)
When Gitea is running as PID 1 git will occassionally orphan child processes leading
to (defunct) processes. This PR simply sets Setpgid to true on these child processes
meaning that these defunct processes will also be correctly reaped.
Fix #19077
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'modules/markup/external/external.go')
-rw-r--r-- | modules/markup/external/external.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/modules/markup/external/external.go b/modules/markup/external/external.go index 4fdd4315bc..a587abcc3b 100644 --- a/modules/markup/external/external.go +++ b/modules/markup/external/external.go @@ -124,6 +124,8 @@ func (p *Renderer) Render(ctx *markup.RenderContext, input io.Reader, output io. cmd.Stdin = input } cmd.Stdout = output + process.SetSysProcAttribute(cmd) + if err := cmd.Run(); err != nil { return fmt.Errorf("%s render run command %s %v failed: %v", p.Name(), commands[0], args, err) } |