summaryrefslogtreecommitdiffstats
path: root/modules/markup/markdown/goldmark.go
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2020-05-24 09:14:26 +0100
committerGitHub <noreply@github.com>2020-05-24 09:14:26 +0100
commit814ca9ffea229f55f1f69b34d9a7f84054115669 (patch)
tree1d6fcfaaa7035a42d6d489c1c57987a645e20615 /modules/markup/markdown/goldmark.go
parent3761bdb640f1aeb9c68b3b491640eb9b0f9f9b0e (diff)
downloadgitea-814ca9ffea229f55f1f69b34d9a7f84054115669.tar.gz
gitea-814ca9ffea229f55f1f69b34d9a7f84054115669.zip
Allow different HardBreaks settings for documents and comments (#11515)
GH has different HardBreaks behaviour for markdown comments and documents. Comments have hard breaks and documents have soft breaks - therefore Gitea's rendering will always be different from GH's if we only provide one setting. Here we split the setting in to two - one for documents and one for comments and other things. Signed-off-by: Andrew Thornton art27@cantab.net Changes to index.js as per @silverwind Co-authored-by: silverwind <me@silverwind.io> Changes to docs as per @guillep2k Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Diffstat (limited to 'modules/markup/markdown/goldmark.go')
-rw-r--r--modules/markup/markdown/goldmark.go10
1 files changed, 10 insertions, 0 deletions
diff --git a/modules/markup/markdown/goldmark.go b/modules/markup/markdown/goldmark.go
index bf02a22d5e..9447424644 100644
--- a/modules/markup/markdown/goldmark.go
+++ b/modules/markup/markdown/goldmark.go
@@ -151,6 +151,16 @@ func (g *ASTTransformer) Transform(node *ast.Document, reader text.Reader, pc pa
v.AppendChild(v, newChild)
}
}
+ case *ast.Text:
+ if v.SoftLineBreak() && !v.HardLineBreak() {
+ renderMetas := pc.Get(renderMetasKey).(map[string]string)
+ mode := renderMetas["mode"]
+ if mode != "document" {
+ v.SetHardLineBreak(setting.Markdown.EnableHardLineBreakInComments)
+ } else {
+ v.SetHardLineBreak(setting.Markdown.EnableHardLineBreakInDocuments)
+ }
+ }
}
return ast.WalkContinue, nil
})