diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2021-10-11 20:12:06 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-11 20:12:06 +0800 |
| commit | d8e06a90f06116134e9b2b661ad404210cc052cd (patch) | |
| tree | 97030f75e36fd1bc53996e8c302d176c60391fa9 /modules/markup/markdown | |
| parent | 758c8c8446b1fb06dba2c9742cc2841cda867761 (diff) | |
| download | gitea-d8e06a90f06116134e9b2b661ad404210cc052cd.tar.gz gitea-d8e06a90f06116134e9b2b661ad404210cc052cd.zip | |
Open markdown image links in new window (#17287)
Diffstat (limited to 'modules/markup/markdown')
| -rw-r--r-- | modules/markup/markdown/goldmark.go | 1 | ||||
| -rw-r--r-- | modules/markup/markdown/markdown_test.go | 11 |
2 files changed, 8 insertions, 4 deletions
diff --git a/modules/markup/markdown/goldmark.go b/modules/markup/markdown/goldmark.go index f1c259f824..43023220a5 100644 --- a/modules/markup/markdown/goldmark.go +++ b/modules/markup/markdown/goldmark.go @@ -114,6 +114,7 @@ func (g *ASTTransformer) Transform(node *ast.Document, reader text.Reader, pc pa wrap := ast.NewLink() wrap.Destination = link wrap.Title = v.Title + wrap.SetAttributeString("target", []byte("_blank")) // Duplicate the current image node image := ast.NewImage(ast.NewLink()) diff --git a/modules/markup/markdown/markdown_test.go b/modules/markup/markdown/markdown_test.go index f22c389531..936e4a39fd 100644 --- a/modules/markup/markdown/markdown_test.go +++ b/modules/markup/markdown/markdown_test.go @@ -8,6 +8,7 @@ import ( "strings" "testing" + "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/markup" . "code.gitea.io/gitea/modules/markup/markdown" "code.gitea.io/gitea/modules/setting" @@ -94,10 +95,11 @@ func TestRender_Images(t *testing.T) { title := "Train" href := "https://gitea.io" result := util.URLJoin(AppSubURL, url) + // hint: With Markdown v2.5.2, there is a new syntax: [link](URL){:target="_blank"} , but we do not support it now test( "!["+title+"]("+url+")", - `<p><a href="`+result+`" rel="nofollow"><img src="`+result+`" alt="`+title+`"/></a></p>`) + `<p><a href="`+result+`" target="_blank" rel="nofollow noopener"><img src="`+result+`" alt="`+title+`"/></a></p>`) test( "[["+title+"|"+url+"]]", @@ -109,7 +111,7 @@ func TestRender_Images(t *testing.T) { url = "/../../.images/src/02/train.jpg" test( "!["+title+"]("+url+")", - `<p><a href="`+result+`" rel="nofollow"><img src="`+result+`" alt="`+title+`"/></a></p>`) + `<p><a href="`+result+`" target="_blank" rel="nofollow noopener"><img src="`+result+`" alt="`+title+`"/></a></p>`) test( "[["+title+"|"+url+"]]", @@ -373,6 +375,7 @@ func TestMarkdownRenderRaw(t *testing.T) { } for _, testcase := range testcases { + log.Info("Test markdown render error with fuzzy data: %x, the following errors can be recovered", testcase) _, err := RenderRawString(&markup.RenderContext{}, string(testcase)) assert.NoError(t, err) } @@ -382,8 +385,8 @@ func TestRenderSiblingImages_Issue12925(t *testing.T) { testcase := `  ` - expected := `<p><a href="/image1" rel="nofollow"><img src="/image1" alt="image1"></a><br> -<a href="/image2" rel="nofollow"><img src="/image2" alt="image2"></a></p> + expected := `<p><a href="/image1" target="_blank" rel="nofollow noopener"><img src="/image1" alt="image1"></a><br> +<a href="/image2" target="_blank" rel="nofollow noopener"><img src="/image2" alt="image2"></a></p> ` res, err := RenderRawString(&markup.RenderContext{}, testcase) assert.NoError(t, err) |