diff options
author | Yarden Shoham <git@yardenshoham.com> | 2023-05-19 18:17:07 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-19 17:17:07 +0200 |
commit | f5ce2ed292a90041abd749a8db26671645648a43 (patch) | |
tree | 22e5223563b637f4a3fb9fdefb5cdae37d7e6eb3 /modules/markup/sanitizer_test.go | |
parent | 38cf43d0606c13c38f459659f38e26cf31dceccb (diff) | |
download | gitea-f5ce2ed292a90041abd749a8db26671645648a43.tar.gz gitea-f5ce2ed292a90041abd749a8db26671645648a43.zip |
Allow all URL schemes in Markdown links by default (#24805)
- Closes #21146
- Closes #16721
## :warning: BREAKING :warning:
This changes the default behavior to now create links for any URL scheme
when the user uses the markdown form for links (`[label](URL)`), this
doesn't affect the rendering of inline links. To opt-out set the
`markdown.CUSTOM_URL_SCHEMES` setting to a list of allowed schemes, all
other schemes (except `http` and `https`) won't be allowed.
# Before
![image](https://github.com/go-gitea/gitea/assets/20454870/35fa18ce-7dda-4995-b5b3-3f360f38296d)
# After
![image](https://github.com/go-gitea/gitea/assets/20454870/0922216b-0b35-4b77-9919-21a5c21dd5d0)
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'modules/markup/sanitizer_test.go')
-rw-r--r-- | modules/markup/sanitizer_test.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/modules/markup/sanitizer_test.go b/modules/markup/sanitizer_test.go index c792ec2dc6..0c22ce3ba0 100644 --- a/modules/markup/sanitizer_test.go +++ b/modules/markup/sanitizer_test.go @@ -52,6 +52,10 @@ func Test_Sanitizer(t *testing.T) { `<span style="bad-color: red">Hello World</span>`, `<span>Hello World</span>`, `<p style="bad-color: red">Hello World</p>`, `<p>Hello World</p>`, `<code style="bad-color: red">Hello World</code>`, `<code>Hello World</code>`, + + // URLs + `[my custom URL scheme](cbthunderlink://somebase64string)`, `[my custom URL scheme](cbthunderlink://somebase64string)`, + `[my custom URL scheme](matrix:roomid/psumPMeAfzgAeQpXMG:feneas.org?action=join)`, `[my custom URL scheme](matrix:roomid/psumPMeAfzgAeQpXMG:feneas.org?action=join)`, } for i := 0; i < len(testCases); i += 2 { |