Support Issue forms and PR forms (#20987)

* feat: extend issue template for yaml

* feat: support yaml template

* feat: render form to markdown

* feat: support yaml template for pr

* chore: rename to Fields

* feat: template unmarshal

* feat: split template

* feat: render to markdown

* feat: use full name as template file name

* chore: remove useless file

* feat: use dropdown of fomantic ui

* feat: update input style

* docs: more comments

* fix: render text without render

* chore: fix lint error

* fix: support use description as about in markdown

* fix: add field class in form

* chore: generate swagger

* feat: validate template

* feat: support is_nummber and regex

* test: fix broken unit tests

* fix: ignore empty body of md template

* fix: make multiple easymde editors work in one page

* feat: better UI

* fix: js error in pr form

* chore: generate swagger

* feat: support regex validation

* chore: generate swagger

* fix: refresh each markdown editor

* chore: give up required validation

* fix: correct issue template candidates

* fix: correct checkboxes style

* chore: ignore .hugo_build.lock in docs

* docs: separate out a new doc for merge templates

* docs: introduce syntax of yaml template

* feat: show a alert for invalid templates

* test: add case for a valid template

* fix: correct attributes of required checkbox

* fix: add class not-under-easymde for dropzone

* fix: use more back-quotes

* chore: remove translation in zh-CN

* fix EasyMDE statusbar margin

* fix: remove repeated blocks

* fix: reuse regex for quotes

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

1 files changed, 13 insertions, 2 deletions

diff --git a/modules/markup/markdown/meta_test.go b/modules/markup/markdown/meta_test.go
index f525777a54..939646f8fd 100644
--- a/modules/markup/markdown/meta_test.go
+++ b/modules/markup/markdown/meta_test.go
@@ -6,6 +6,7 @@ package markdown
 
 import (
 	"fmt"
+	"strings"
 	"testing"
 
 	"code.gitea.io/gitea/modules/structs"
@@ -13,6 +14,16 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func validateMetadata(it structs.IssueTemplate) bool {
+	/*
+		A legacy to keep the unit tests working.
+		Copied from the method "func (it IssueTemplate) Valid() bool", the original method has been removed.
+		Because it becomes quite complicated to validate an issue template which is support yaml form now.
+		The new way to validate an issue template is to call the Validate in modules/issue/template,
+	*/
+	return strings.TrimSpace(it.Name) != "" && strings.TrimSpace(it.About) != ""
+}
+
 func TestExtractMetadata(t *testing.T) {
 	t.Run("ValidFrontAndBody", func(t *testing.T) {
 		var meta structs.IssueTemplate
@@ -20,7 +31,7 @@ func TestExtractMetadata(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Equal(t, bodyTest, body)
 		assert.Equal(t, metaTest, meta)
-		assert.True(t, meta.Valid())
+		assert.True(t, validateMetadata(meta))
 	})
 
 	t.Run("NoFirstSeparator", func(t *testing.T) {
@@ -41,7 +52,7 @@ func TestExtractMetadata(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Equal(t, "", body)
 		assert.Equal(t, metaTest, meta)
-		assert.True(t, meta.Valid())
+		assert.True(t, validateMetadata(meta))
 	})
 }