diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-06-03 22:03:41 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-03 22:03:41 +0800 |
| commit | 520eb57d7642a5fca3df319e5b5d1c7c9018087c (patch) | |
| tree | a697c0be092c2fba660336a6bbebcee47e56c407 /modules/metrics | |
| parent | 4486dd39e7f6062926d72e0d104ed303eb01a400 (diff) | |
| download | gitea-520eb57d7642a5fca3df319e5b5d1c7c9018087c.tar.gz gitea-520eb57d7642a5fca3df319e5b5d1c7c9018087c.zip | |
Use a separate admin page to show global stats, remove `actions` stat (#25062)
Before, Gitea shows the database table stats on the `admin dashboard`
page.
It has some problems:
* `count(*)` is quite heavy. If tables have many records, this blocks
loading the admin page blocks for a long time
* Some users had even reported issues that they can't visit their admin
page because this page causes blocking or `50x error (reverse proxy
timeout)`
* The `actions` stat is not useful. The table is simply too large. Does
it really matter if it contains 1,000,000 rows or 9,999,999 rows?
* The translation `admin.dashboard.statistic_info` is difficult to
maintain.
So, this PR uses a separate page to show the stats and removes the
`actions` stat.
## :warning: BREAKING
The `actions` Prometheus metrics collector has been removed for the
reasons mentioned beforehand.
Please do not rely on its output anymore.
Diffstat (limited to 'modules/metrics')
| -rwxr-xr-x | modules/metrics/collector.go | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/modules/metrics/collector.go b/modules/metrics/collector.go index 94699c161c..33678256c3 100755 --- a/modules/metrics/collector.go +++ b/modules/metrics/collector.go @@ -18,7 +18,6 @@ const namespace = "gitea_" // exposes gitea metrics for prometheus type Collector struct { Accesses *prometheus.Desc - Actions *prometheus.Desc Attachments *prometheus.Desc BuildInfo *prometheus.Desc Comments *prometheus.Desc @@ -56,11 +55,6 @@ func NewCollector() Collector { "Number of Accesses", nil, nil, ), - Actions: prometheus.NewDesc( - namespace+"actions", - "Number of Actions", - nil, nil, - ), Attachments: prometheus.NewDesc( namespace+"attachments", "Number of Attachments", @@ -207,7 +201,6 @@ func NewCollector() Collector { // Describe returns all possible prometheus.Desc func (c Collector) Describe(ch chan<- *prometheus.Desc) { ch <- c.Accesses - ch <- c.Actions ch <- c.Attachments ch <- c.BuildInfo ch <- c.Comments @@ -247,11 +240,6 @@ func (c Collector) Collect(ch chan<- prometheus.Metric) { float64(stats.Counter.Access), ) ch <- prometheus.MustNewConstMetric( - c.Actions, - prometheus.GaugeValue, - float64(stats.Counter.Action), - ) - ch <- prometheus.MustNewConstMetric( c.Attachments, prometheus.GaugeValue, float64(stats.Counter.Attachment), |