diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /modules/nosql | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'modules/nosql')
| -rw-r--r-- | modules/nosql/manager.go | 2 | ||||
| -rw-r--r-- | modules/nosql/manager_leveldb.go | 2 | ||||
| -rw-r--r-- | modules/nosql/manager_redis.go | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/modules/nosql/manager.go b/modules/nosql/manager.go index 93338fdc3f..6092a67827 100644 --- a/modules/nosql/manager.go +++ b/modules/nosql/manager.go @@ -75,5 +75,5 @@ func valToTimeDuration(vs []string) (result time.Duration) { return } } - return + return result } diff --git a/modules/nosql/manager_leveldb.go b/modules/nosql/manager_leveldb.go index d69ae88800..d356a79bf8 100644 --- a/modules/nosql/manager_leveldb.go +++ b/modules/nosql/manager_leveldb.go @@ -72,7 +72,7 @@ func (m *Manager) GetLevelDB(connection string) (db *leveldb.DB, err error) { if recovered != nil { panic(recovered) } - return + return db, err } func (m *Manager) getLevelDB(connection string) (*leveldb.DB, error) { diff --git a/modules/nosql/manager_redis.go b/modules/nosql/manager_redis.go index b82f899db0..3b2ad75b41 100644 --- a/modules/nosql/manager_redis.go +++ b/modules/nosql/manager_redis.go @@ -65,7 +65,7 @@ func (m *Manager) GetRedisClient(connection string) (client redis.UniversalClien if recovered != nil { panic(recovered) } - return + return client } func (m *Manager) getRedisClient(connection string) redis.UniversalClient { |