diff options
| author | zeripath <art27@cantab.net> | 2020-10-30 19:26:03 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-30 15:26:03 -0400 |
| commit | dd12384f224e98a130511ebc9ffcfb44ead0e736 (patch) | |
| tree | 9c100624bdfce918f487ad14d6287acfd01d9aad /modules/notification/webhook/webhook.go | |
| parent | 20a5eff3e81f17e3d5e5ccc1c1d0b982241ba9ad (diff) | |
| download | gitea-dd12384f224e98a130511ebc9ffcfb44ead0e736.tar.gz gitea-dd12384f224e98a130511ebc9ffcfb44ead0e736.zip | |
Fix --port setting (#13288)
* Fix --port setting
Unfortunately there was an error in #13195 which set the --port
option before the settings were read. This PR fixes this by
moving applying this option to after the the settings are read
However, on looking further into this code I believe that the setPort
code was slightly odd.
Firstly, it may make sense to run the install page on a different
temporary port to the full system and this should be possible with
a --install-port option.
Secondy, if the --port option is provided we should apply it to both
otherwise there will be unusual behaviour on graceful restart
Thirdly, the documentation for --port says that the setting is
temporary - it should therefore not save its result to the configuration
(This however, does mean that authorized_keys and internal links may
not be correct. - I think we need to discuss this option further.)
Fix #13277
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update cmd/web.go
* Apply suggestions from code review
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Diffstat (limited to 'modules/notification/webhook/webhook.go')
0 files changed, 0 insertions, 0 deletions