diff options
author | mrsdizzie <joe.mccann@gmail.com> | 2019-03-07 14:13:44 -0500 |
---|---|---|
committer | techknowlogick <matti@mdranta.net> | 2019-03-07 14:13:44 -0500 |
commit | 020075e12fe4f3bc4fb632909309da97ed537c34 (patch) | |
tree | 3102bbd2b6b8106e40ab2e69400edce0d7b8833d /modules/options/dynamic.go | |
parent | ad86b843e1d1984ec1b69f51276654469644bdd5 (diff) | |
download | gitea-020075e12fe4f3bc4fb632909309da97ed537c34.tar.gz gitea-020075e12fe4f3bc4fb632909309da97ed537c34.zip |
Remove visitLinksForShortLinks features (#6257)
The visitLinksForShortLinks feature would look inside of an <a> tag and
run shortLinkProcessorFull on any text, which attempts to create links
out of potential 'short links' like [[test]] [[link|example]] etc...
This makes no sense because you can't have nested links within an <a>
tag. Specifically, the html5 standard says <a> tags can't include
interactive content if they contain the href attribute:
http://w3c.github.io/html/single-page.html#the-a-element
And also defines an <a> element with a href attribute as interactive:
http://w3c.github.io/html/single-page.html#interactive-content
Therefore you can't really put a link inside of another link. In
practice none of this works anyways since browsers won't render it, it
would probably be broken if they tried, and it is causing a bug
(#4946). No current tests rely on this behavior either.
This removes the feature and also explicitly excludes the
current visitNodeForShortLinks from looking in <a> tags.
Diffstat (limited to 'modules/options/dynamic.go')
0 files changed, 0 insertions, 0 deletions