summaryrefslogtreecommitdiffstats
path: root/modules/process/manager_unix.go
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2022-06-03 15:36:18 +0100
committerGitHub <noreply@github.com>2022-06-03 15:36:18 +0100
commit1d04e8641d4abab6ce978bc2dc5523c2ddb2f628 (patch)
tree742564159535d13dd060074187be79616da2bb3f /modules/process/manager_unix.go
parent085924b1b370310c989fa5e75bb33323746382b0 (diff)
downloadgitea-1d04e8641d4abab6ce978bc2dc5523c2ddb2f628.tar.gz
gitea-1d04e8641d4abab6ce978bc2dc5523c2ddb2f628.zip
Set Setpgid on child git processes (#19865)
When Gitea is running as PID 1 git will occassionally orphan child processes leading to (defunct) processes. This PR simply sets Setpgid to true on these child processes meaning that these defunct processes will also be correctly reaped. Fix #19077 Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'modules/process/manager_unix.go')
-rw-r--r--modules/process/manager_unix.go18
1 files changed, 18 insertions, 0 deletions
diff --git a/modules/process/manager_unix.go b/modules/process/manager_unix.go
new file mode 100644
index 0000000000..1e7c77fdbf
--- /dev/null
+++ b/modules/process/manager_unix.go
@@ -0,0 +1,18 @@
+// Copyright 2022 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+//go:build !windows
+
+package process
+
+import (
+ "os/exec"
+ "syscall"
+)
+
+// SetSysProcAttribute sets the common SysProcAttrs for commands
+func SetSysProcAttribute(cmd *exec.Cmd) {
+ // When Gitea runs SubProcessA -> SubProcessB and SubProcessA gets killed by context timeout, use setpgid to make sure the sub processes can be reaped instead of leaving defunct(zombie) processes.
+ cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+}