diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /modules/process | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'modules/process')
| -rw-r--r-- | modules/process/manager.go | 2 | ||||
| -rw-r--r-- | modules/process/manager_stacktraces.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/modules/process/manager.go b/modules/process/manager.go index 5d7aee760f..7f14287de5 100644 --- a/modules/process/manager.go +++ b/modules/process/manager.go @@ -183,7 +183,7 @@ func (pm *Manager) nextPID() (start time.Time, pid IDType) { return } pid = IDType(string(pid) + "-" + strconv.FormatInt(pm.next, 10)) - return + return start, pid } // Remove a process from the ProcessManager. diff --git a/modules/process/manager_stacktraces.go b/modules/process/manager_stacktraces.go index fbe3374b87..628d9cebcd 100644 --- a/modules/process/manager_stacktraces.go +++ b/modules/process/manager_stacktraces.go @@ -120,7 +120,7 @@ func (pm *Manager) ProcessStacktraces(flat, noSystem bool) ([]*Process, int, int // We cannot use the pm.ProcessMap here because we will release the mutex ... processMap := map[IDType]*Process{} - processCount := 0 + var processCount int // Lock the manager pm.mutex.Lock() |