summaryrefslogtreecommitdiffstats
path: root/modules/setting
diff options
context:
space:
mode:
authorwxiaoguang <wxiaoguang@gmail.com>2022-07-08 16:09:07 +0800
committerGitHub <noreply@github.com>2022-07-08 16:09:07 +0800
commit496b8e39900842c8253250d3eaddf587be35dfa3 (patch)
treeced6cb1eba452fcbb92b295ea8f478b3f6ab5492 /modules/setting
parentc273dea5085aece451b10d78799d879c28e8a752 (diff)
downloadgitea-496b8e39900842c8253250d3eaddf587be35dfa3.tar.gz
gitea-496b8e39900842c8253250d3eaddf587be35dfa3.zip
Use git.HOME_PATH for Git HOME directory (#20114)
* Add git.HOME_PATH * add legacy file check * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> * pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear. * set git.HOME_PATH for docker images to default HOME * Revert "set git.HOME_PATH for docker images to default HOME" This reverts commit f120101ddc267cef74e4f4b92c783d5fc8e275a1. * force Gitea to use a stable GNUPGHOME directory * extra check to ensure only process dir or symlink for legacy files * refactor variable name * The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable * Update modules/git/git.go Co-authored-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com> * remove initFixGitHome117rc * Update git.go * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'modules/setting')
-rw-r--r--modules/setting/git.go13
1 files changed, 12 insertions, 1 deletions
diff --git a/modules/setting/git.go b/modules/setting/git.go
index 9b2698f01e..266bbc3c5a 100644
--- a/modules/setting/git.go
+++ b/modules/setting/git.go
@@ -5,6 +5,7 @@
package setting
import (
+ "path/filepath"
"time"
"code.gitea.io/gitea/modules/log"
@@ -13,6 +14,7 @@ import (
// Git settings
var Git = struct {
Path string
+ HomePath string
DisableDiffHighlight bool
MaxGitDiffLines int
MaxGitDiffLineCharacters int
@@ -67,7 +69,16 @@ var Git = struct {
}
func newGit() {
- if err := Cfg.Section("git").MapTo(&Git); err != nil {
+ sec := Cfg.Section("git")
+
+ if err := sec.MapTo(&Git); err != nil {
log.Fatal("Failed to map Git settings: %v", err)
}
+
+ Git.HomePath = sec.Key("HOME_PATH").MustString("home")
+ if !filepath.IsAbs(Git.HomePath) {
+ Git.HomePath = filepath.Join(AppDataPath, Git.HomePath)
+ } else {
+ Git.HomePath = filepath.Clean(Git.HomePath)
+ }
}