diff options
| author | Felipe Leopoldo Sologuren Gutiérrez <fsologureng@users.noreply.github.com> | 2023-01-16 13:21:44 -0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-16 16:21:44 +0000 |
| commit | 04c97aa36473bc0070a2fe46e86dc645dc75ee85 (patch) | |
| tree | 409f98cebeaac4b9f8b2482574963c78897710bc /modules/storage | |
| parent | da274380a7be72e0153a448611278b402e20ad7e (diff) | |
| download | gitea-04c97aa36473bc0070a2fe46e86dc645dc75ee85.tar.gz gitea-04c97aa36473bc0070a2fe46e86dc645dc75ee85.zip | |
Change use of Walk to WalkDir to improve disk performance (#22462)
As suggest by Go developers, use `filepath.WalkDir` instead of
`filepath.Walk` because [*Walk is less efficient than WalkDir,
introduced in Go 1.16, which avoids calling `os.Lstat` on every file or
directory visited](https://pkg.go.dev/path/filepath#Walk).
This proposition address that, in a similar way as
https://github.com/go-gitea/gitea/pull/22392 did.
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'modules/storage')
| -rw-r--r-- | modules/storage/local.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/storage/local.go b/modules/storage/local.go index ca51d26c9a..a6a9d54a8c 100644 --- a/modules/storage/local.go +++ b/modules/storage/local.go @@ -129,7 +129,7 @@ func (l *LocalStorage) URL(path, name string) (*url.URL, error) { // IterateObjects iterates across the objects in the local storage func (l *LocalStorage) IterateObjects(fn func(path string, obj Object) error) error { - return filepath.Walk(l.dir, func(path string, info os.FileInfo, err error) error { + return filepath.WalkDir(l.dir, func(path string, d os.DirEntry, err error) error { if err != nil { return err } @@ -141,7 +141,7 @@ func (l *LocalStorage) IterateObjects(fn func(path string, obj Object) error) er if path == l.dir { return nil } - if info.IsDir() { + if d.IsDir() { return nil } relPath, err := filepath.Rel(l.dir, path) |