diff options
| author | Nulo (he/him) <86896666+catdevnull@users.noreply.github.com> | 2022-09-24 13:04:14 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-24 21:04:14 +0800 |
| commit | cca189ef97d5f9fd3f52c75ec6e1ae916916cd08 (patch) | |
| tree | 593bd91a628b337699048bfc31363e7c6225321e /modules/storage | |
| parent | 83680c97a7fd23d2a2953302771ed2b234c0689e (diff) | |
| download | gitea-cca189ef97d5f9fd3f52c75ec6e1ae916916cd08.tar.gz gitea-cca189ef97d5f9fd3f52c75ec6e1ae916916cd08.zip | |
Save files in local storage as umask (#21198)
Go creates temporary files as 600, but sometimes we want the group to be able to read them (for example,
for another user to back up the storage)
This PR applies the umask to the renamed tmp files in local storage.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Diffstat (limited to 'modules/storage')
| -rw-r--r-- | modules/storage/local.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/modules/storage/local.go b/modules/storage/local.go index 701b0b1a9f..5d5b06b648 100644 --- a/modules/storage/local.go +++ b/modules/storage/local.go @@ -102,6 +102,10 @@ func (l *LocalStorage) Save(path string, r io.Reader, size int64) (int64, error) if err := util.Rename(tmp.Name(), p); err != nil { return 0, err } + // Golang's tmp file (os.CreateTemp) always have 0o600 mode, so we need to change the file to follow the umask (as what Create/MkDir does) + if err := util.ApplyUmask(p, os.ModePerm); err != nil { + return 0, err + } tmpRemoved = true |