diff options
| author | Jason Song <i@wolfogre.com> | 2023-06-22 21:08:08 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-22 13:08:08 +0000 |
| commit | 174213530dc538c124cddc5cc43d9a514c6695b9 (patch) | |
| tree | 061bdae4a57ed1ca17d1b85bb4c7ab69fe673d71 /modules/structs/repo.go | |
| parent | 7fb539677b448a9cc554e71afb98da558f3e0631 (diff) | |
| download | gitea-174213530dc538c124cddc5cc43d9a514c6695b9.tar.gz gitea-174213530dc538c124cddc5cc43d9a514c6695b9.zip | |
Fix `Permission` in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.
Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)
---
Review tips:
The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101
And other changes are passive.
Diffstat (limited to 'modules/structs/repo.go')
| -rw-r--r-- | modules/structs/repo.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/modules/structs/repo.go b/modules/structs/repo.go index fc4ed03de5..3b43f74c79 100644 --- a/modules/structs/repo.go +++ b/modules/structs/repo.go @@ -10,9 +10,9 @@ import ( // Permission represents a set of permissions type Permission struct { - Admin bool `json:"admin"` - Push bool `json:"push"` - Pull bool `json:"pull"` + Admin bool `json:"admin"` // Admin indicates if the user is an administrator of the repository. + Push bool `json:"push"` // Push indicates if the user can push code to the repository. + Pull bool `json:"pull"` // Pull indicates if the user can pull code from the repository. } // InternalTracker represents settings for internal tracker |