summaryrefslogtreecommitdiffstats
path: root/modules/templates/helper_test.go
diff options
context:
space:
mode:
authorWim <wim@42.be>2022-06-20 12:02:49 +0200
committerGitHub <noreply@github.com>2022-06-20 12:02:49 +0200
commitcb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch)
tree938af0f442baf79cebd114692aff5ad6af37f987 /modules/templates/helper_test.go
parent3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff)
downloadgitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz
gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability - nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length. - unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions - wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements. - notlintlint - Reports ill-formed or insufficient nolint directives - stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent - excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'modules/templates/helper_test.go')
-rw-r--r--modules/templates/helper_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/templates/helper_test.go b/modules/templates/helper_test.go
index e2997cb853..5ebae7afef 100644
--- a/modules/templates/helper_test.go
+++ b/modules/templates/helper_test.go
@@ -17,8 +17,8 @@ func TestSubjectBodySeparator(t *testing.T) {
assert.Empty(t, subject, "no subject found, but one expected")
assert.Equal(t, body, input)
} else {
- assert.Equal(t, subject, string(input[0:loc[0]]))
- assert.Equal(t, body, string(input[loc[1]:]))
+ assert.Equal(t, subject, input[0:loc[0]])
+ assert.Equal(t, body, input[loc[1]:])
}
}