diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /modules/templates | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'modules/templates')
| -rw-r--r-- | modules/templates/helper.go | 4 | ||||
| -rw-r--r-- | modules/templates/helper_test.go | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/modules/templates/helper.go b/modules/templates/helper.go index 99b1979964..93463ce0c2 100644 --- a/modules/templates/helper.go +++ b/modules/templates/helper.go @@ -733,7 +733,7 @@ func RenderCommitMessageLink(ctx context.Context, msg, urlPrefix, urlDefault str log.Error("RenderCommitMessage: %v", err) return "" } - msgLines := strings.Split(strings.TrimSpace(string(fullMessage)), "\n") + msgLines := strings.Split(strings.TrimSpace(fullMessage), "\n") if len(msgLines) == 0 { return template.HTML("") } @@ -843,7 +843,7 @@ func RenderNote(ctx context.Context, msg, urlPrefix string, metas map[string]str log.Error("RenderNote: %v", err) return "" } - return template.HTML(string(fullMessage)) + return template.HTML(fullMessage) } // IsMultilineCommitMessage checks to see if a commit message contains multiple lines. diff --git a/modules/templates/helper_test.go b/modules/templates/helper_test.go index e2997cb853..5ebae7afef 100644 --- a/modules/templates/helper_test.go +++ b/modules/templates/helper_test.go @@ -17,8 +17,8 @@ func TestSubjectBodySeparator(t *testing.T) { assert.Empty(t, subject, "no subject found, but one expected") assert.Equal(t, body, input) } else { - assert.Equal(t, subject, string(input[0:loc[0]])) - assert.Equal(t, body, string(input[loc[1]:])) + assert.Equal(t, subject, input[0:loc[0]]) + assert.Equal(t, body, input[loc[1]:]) } } |