diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-05-04 14:36:34 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-04 14:36:34 +0800 |
| commit | 5d77691d428d5302ee4df6c2a936b8e2ea9dca7e (patch) | |
| tree | 4fa6b13f2ae81c5de94d84f2288ae1f5653c011f /modules/test | |
| parent | 75ea0d5dba5dbf2f84cef2d12460fdd566d43e62 (diff) | |
| download | gitea-5d77691d428d5302ee4df6c2a936b8e2ea9dca7e.tar.gz gitea-5d77691d428d5302ee4df6c2a936b8e2ea9dca7e.zip | |
Improve template system and panic recovery (#24461)
Partially for #24457
Major changes:
1. The old `signedUserNameStringPointerKey` is quite hacky, use
`ctx.Data[SignedUser]` instead
2. Move duplicate code from `Contexter` to `CommonTemplateContextData`
3. Remove incorrect copying&pasting code `ctx.Data["Err_Password"] =
true` in API handlers
4. Use one unique `RenderPanicErrorPage` for panic error page rendering
5. Move `stripSlashesMiddleware` to be the first middleware
6. Install global panic recovery handler, it works for both `install`
and `web`
7. Make `500.tmpl` only depend minimal template functions/variables,
avoid triggering new panics
Screenshot:
<details>
</details>
Diffstat (limited to 'modules/test')
| -rw-r--r-- | modules/test/context_tests.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/test/context_tests.go b/modules/test/context_tests.go index 4af7651250..35dd920bb9 100644 --- a/modules/test/context_tests.go +++ b/modules/test/context_tests.go @@ -30,7 +30,7 @@ func MockContext(t *testing.T, path string) *context.Context { resp := &mockResponseWriter{} ctx := context.Context{ Render: &mockRender{}, - Data: make(map[string]interface{}), + Data: make(middleware.ContextData), Flash: &middleware.Flash{ Values: make(url.Values), }, |