diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /modules/timeutil | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'modules/timeutil')
| -rw-r--r-- | modules/timeutil/since.go | 4 | ||||
| -rw-r--r-- | modules/timeutil/timestamp.go | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/modules/timeutil/since.go b/modules/timeutil/since.go index 38b12829ad..b22fe59ba2 100644 --- a/modules/timeutil/since.go +++ b/modules/timeutil/since.go @@ -30,7 +30,7 @@ func round(s float64) int64 { } func computeTimeDiffFloor(diff int64, lang string) (int64, string) { - diffStr := "" + var diffStr string switch { case diff <= 0: diff = 0 @@ -88,7 +88,7 @@ func computeTimeDiffFloor(diff int64, lang string) (int64, string) { } func computeTimeDiff(diff int64, lang string) (int64, string) { - diffStr := "" + var diffStr string switch { case diff <= 0: diff = 0 diff --git a/modules/timeutil/timestamp.go b/modules/timeutil/timestamp.go index 1fe8d4fcb1..88008d1fad 100644 --- a/modules/timeutil/timestamp.go +++ b/modules/timeutil/timestamp.go @@ -57,7 +57,7 @@ func (ts TimeStamp) AsTime() (tm time.Time) { // AsTimeInLocation convert timestamp as time.Time in Local locale func (ts TimeStamp) AsTimeInLocation(loc *time.Location) (tm time.Time) { tm = time.Unix(int64(ts), 0).In(loc) - return + return tm } // AsTimePtr convert timestamp as *time.Time in Local locale |