diff options
| author | mrsdizzie <info@mrsdizzie.com> | 2019-03-26 15:59:48 -0400 |
|---|---|---|
| committer | Lauris BH <lauris@nix.lv> | 2019-03-26 21:59:48 +0200 |
| commit | d056bf300ff5ebd89d8b0035722c94a3b08ac745 (patch) | |
| tree | 731708f1ddc55c1c406b5c7670a998e827e0cecc /modules/validation/binding.go | |
| parent | b4941f707b0fd950fc2a0b12b34fbc37206e23dd (diff) | |
| download | gitea-d056bf300ff5ebd89d8b0035722c94a3b08ac745.tar.gz gitea-d056bf300ff5ebd89d8b0035722c94a3b08ac745.zip | |
Clean up ref name rules (#6437)
* Clean up ref name rules
Clean up checks on reference names to better conform to the guideline
here: https://git-scm.com/docs/git-check-ref-format
This fixes half of #6321
* Update branch create integration test
According to: https://git-scm.com/docs/git-check-ref-format
And: git check-ref-format "master/feature=test1"
This is a valid branch name and we should not be testing for it to fail.
Diffstat (limited to 'modules/validation/binding.go')
| -rw-r--r-- | modules/validation/binding.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/modules/validation/binding.go b/modules/validation/binding.go index bf3e6c4f92..03b6f6276d 100644 --- a/modules/validation/binding.go +++ b/modules/validation/binding.go @@ -19,7 +19,9 @@ const ( var ( // GitRefNamePattern is regular expression with unallowed characters in git reference name - GitRefNamePattern = regexp.MustCompile("[^\\d\\w-_\\./]") + // They cannot have ASCII control characters (i.e. bytes whose values are lower than \040, or \177 DEL), space, tilde ~, caret ^, or colon : anywhere. + // They cannot have question-mark ?, asterisk *, or open bracket [ anywhere + GitRefNamePattern = regexp.MustCompile(`[\000-\037\177 \\~^:?*[]+`) ) // AddBindingRules adds additional binding rules @@ -44,7 +46,8 @@ func addGitRefNameBindingRule() { // Additional rules as described at https://www.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html if strings.HasPrefix(str, "/") || strings.HasSuffix(str, "/") || strings.HasSuffix(str, ".") || strings.Contains(str, "..") || - strings.Contains(str, "//") { + strings.Contains(str, "//") || strings.Contains(str, "@{") || + str == "@" { errs.Add([]string{name}, ErrGitRefName, "GitRefName") return false, errs } |