Correction for #723

Correction for #723
Bug was : decode failed if the password contains ```:```

1 files changed, 4 insertions, 4 deletions

diff --git a/modules/base/tool.go b/modules/base/tool.go
index 14c0e7d086..39d3e8abdc 100644
--- a/modules/base/tool.go
+++ b/modules/base/tool.go
@@ -48,11 +48,11 @@ func BasicAuthDecode(encoded string) (user string, name string, err error) {
 		return user, name, err
 	}
 
-	a := strings.Split(string(s), ":")
-	if len(a) == 2 {
-		user, name = a[0], a[1]
-	} else {
+	a := strings.SplitN(string(s), ":", 2)
+	if len(a) != 2 {
 		err = errors.New("decode failed")
+	} else {
+		user, name = a[0], a[1]
 	}
 	return user, name, err
 }