aboutsummaryrefslogtreecommitdiffstats
path: root/modules
diff options
context:
space:
mode:
authorUnknwon <u@gogs.io>2016-03-18 06:13:16 -0400
committerUnknwon <u@gogs.io>2016-03-18 06:13:16 -0400
commit9e09e4850283b2b521f6087418d5d165bcc7cf8f (patch)
treede37a9598d3ab094127089c56ce4895dd8fb01b5 /modules
parentc79774e8d48faed4a04be80eb0ede3fbc4276d4a (diff)
downloadgitea-9e09e4850283b2b521f6087418d5d165bcc7cf8f.tar.gz
gitea-9e09e4850283b2b521f6087418d5d165bcc7cf8f.zip
#2850 fix potential SSH commands dislocation
When use builtin SSH server with concurrent operations, there are probabilities One connection could use the command from another connections. Fix this by set SSH_ORIGINAL_COMMAND for each command, not set in global scope.
Diffstat (limited to 'modules')
-rw-r--r--modules/ssh/ssh.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/ssh/ssh.go b/modules/ssh/ssh.go
index 18313d1ef8..ceecc9bbfc 100644
--- a/modules/ssh/ssh.go
+++ b/modules/ssh/ssh.go
@@ -62,12 +62,12 @@ func handleServerConn(keyID string, chans <-chan ssh.NewChannel) {
}
case "exec":
cmdName := strings.TrimLeft(payload, "'()")
- os.Setenv("SSH_ORIGINAL_COMMAND", cmdName)
log.Trace("SSH: Payload: %v", cmdName)
args := []string{"serv", "key-" + keyID, "--config=" + setting.CustomConf}
log.Trace("SSH: Arguments: %v", args)
cmd := exec.Command(setting.AppPath, args...)
+ cmd.Env = append(os.Environ(), "SSH_ORIGINAL_COMMAND="+cmdName)
stdout, err := cmd.StdoutPipe()
if err != nil {
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-23 15:34:07 +0000
155' href='#n155'>155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 
<!DOCTYPE html>
<html>
<head data-suburl="{{AppSubUrl}}">
	<meta charset="utf-8">
	<meta name="viewport" content="width=device-width, initial-scale=1">
	<meta http-equiv="x-ua-compatible" content="ie=edge">
	<title>{{if .Title}}{{.Title}} - {{end}}{{AppName}}</title>
	<meta name="theme-color" content="{{ThemeColorMetaTag}}">
	<meta name="author" content="{{if .Repository}}{{.Owner.Name}}{{else}}{{MetaAuthor}}{{end}}" />
	<meta name="description" content="{{if .Repository}}{{.Repository.Name}}{{if .Repository.Description}} - {{.Repository.Description}}{{end}}{{else}}{{MetaDescription}}{{end}}" />
	<meta name="keywords" content="{{MetaKeywords}}">
	<meta name="referrer" content="no-referrer" />
	<meta name="_csrf" content="{{.CsrfToken}}" />
	<meta name="_suburl" content="{{AppSubUrl}}" />
	{{if .IsSigned}}
		<meta name="_uid" content="{{.SignedUser.ID}}" />
	{{end}}
	{{if .ContextUser}}
		<meta name="_context_uid" content="{{.ContextUser.ID}}" />
	{{end}}
	{{if .SearchLimit}}
		<meta name="_search_limit" content="{{.SearchLimit}}" />
	{{end}}
{{if .GoGetImport}}
	<meta name="go-import" content="{{.GoGetImport}} git {{.CloneLink.HTTPS}}">
	<meta name="go-source" content="{{.GoGetImport}} _ {{.GoDocDirectory}} {{.GoDocFile}}">
{{end}}

	<script>
	{{SafeJS `/*
	@licstart  The following is the entire license notice for the
        JavaScript code in this page.

	Copyright (c) 2016 The Gitea Authors
	Copyright (c) 2015 The Gogs Authors

	Permission is hereby granted, free of charge, to any person obtaining a copy
	of this software and associated documentation files (the "Software"), to deal
	in the Software without restriction, including without limitation the rights
	to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
	copies of the Software, and to permit persons to whom the Software is
	furnished to do so, subject to the following conditions:

	The above copyright notice and this permission notice shall be included in
	all copies or substantial portions of the Software.

	THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
	AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
	OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
	THE SOFTWARE.
	---
	Licensing information for additional javascript libraries can be found at:
	  {{AppSubUrl}}/vendor/librejs.html

	@licend  The above is the entire license notice
        for the JavaScript code in this page.
	*/`}}
	</script>

	<link rel="shortcut icon" href="{{AppSubUrl}}/img/favicon.png" />
	<link rel="mask-icon" href="{{AppSubUrl}}/img/gitea-safari.svg" color="#609926">
	<link rel="preload" href="{{AppSubUrl}}/vendor/assets/font-awesome/css/font-awesome.min.css" as="style" onload="this.rel='stylesheet'">
	<noscript><link rel="stylesheet" href="{{AppSubUrl}}/vendor/assets/font-awesome/css/font-awesome.min.css"></noscript>
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/assets/octicons/octicons.min.css">

{{if .RequireSimpleMDE}}
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/simplemde/simplemde.min.css">
{{end}}

{{if .RequireGitGraph}}
	<!-- graph -->
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/gitgraph/gitgraph.css">
{{end}}

{{if .RequireTribute}}
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/tribute/tribute.css">
{{end}}

	<!-- Stylesheet -->
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/semantic/semantic.min.css">
	<link rel="stylesheet" href="{{AppSubUrl}}/css/index.css?v={{MD5 AppVer}}">
	<noscript>
		<style>
			.dropdown:hover > .menu { display: block; }
			.ui.secondary.menu .dropdown.item > .menu { margin-top: 0; }
		</style>
	</noscript>

{{if .RequireHighlightJS}}
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/highlight/github.css">
{{end}}
{{if .RequireMinicolors}}
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/jquery.minicolors/jquery.minicolors.css">
{{end}}
{{if .RequireDatetimepicker}}
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/jquery.datetimepicker/jquery.datetimepicker.css">
{{end}}
{{if .RequireDropzone}}
	<link rel="stylesheet" href="{{AppSubUrl}}/vendor/plugins/dropzone/dropzone.css">
{{end}}
	<style class="list-search-style"></style>

	<script src="{{AppSubUrl}}/vendor/plugins/cssrelpreload/loadCSS.min.js"></script>
	<script src="{{AppSubUrl}}/vendor/plugins/cssrelpreload/cssrelpreload.min.js"></script>
{{if .PageIsUserProfile}}
	<meta property="og:title" content="{{.Owner.Name}}" />
	<meta property="og:type" content="profile" />
	<meta property="og:image" content="{{.Owner.AvatarLink}}" />
	<meta property="og:url" content="{{.Owner.HTMLURL}}" />
	<meta property="og:site_name" content="{{AppName}}" />
{{else if .Repository}}
	<meta property="og:title" content="{{.Repository.Name}}" />
	<meta property="og:type" content="object" />
	<meta property="og:image" content="{{.Repository.Owner.AvatarLink}}" />
	<meta property="og:url" content="{{.Repository.HTMLURL}}" />
	{{if .Repository.Description}}
	<meta property="og:description" content="{{.Repository.Description}}" />
	{{end}}
	<meta property="og:site_name" content="{{AppName}}" />
{{else}}
	<meta property="og:title" content="{{AppName}}">
	<meta property="og:type" content="website" />
	<meta property="og:image" content="{{AppSubUrl}}/img/gitea-lg.png" />
	<meta property="og:url" content="{{AppUrl}}" />
	<meta property="og:description" content="{{MetaDescription}}">
{{end}}
{{if ne DefaultTheme "gitea"}}
	<link rel="stylesheet" href="{{AppSubUrl}}/css/theme-{{DefaultTheme}}.css">
{{end}}
{{template "custom/header" .}}
</head>
<body>
	{{template "custom/body_outer_pre" .}}

	<div class="full height">
		<noscript>{{.i18n.Tr "enable_javascript"}}</noscript>

		{{template "custom/body_inner_pre" .}}

		{{if not .PageIsInstall}}
			<div class="ui top secondary stackable main menu following bar light">
				<div class="ui container" id="navbar">
					<div class="item brand" style="justify-content: space-between;">
						<a href="{{AppSubUrl}}/">
							<img class="ui mini image" src="{{AppSubUrl}}/img/gitea-sm.png">
						</a>
						<div class="ui basic icon button mobile-only" id="navbar-expand-toggle">
							<i class="sidebar icon"></i>
						</div>
					</div>

					{{if .IsSigned}}
						<a class="item {{if .PageIsDashboard}}active{{end}}" href="{{AppSubUrl}}/">{{.i18n.Tr "dashboard"}}</a>
						<a class="item {{if .PageIsIssues}}active{{end}}" href="{{AppSubUrl}}/issues">{{.i18n.Tr "issues"}}</a>
						<a class="item {{if .PageIsPulls}}active{{end}}" href="{{AppSubUrl}}/pulls">{{.i18n.Tr "pull_requests"}}</a>
						<a class="item {{if .PageIsExplore}}active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.i18n.Tr "explore"}}</a>
					{{else if .IsLandingPageHome}}
						<a class="item {{if .PageIsHome}}active{{end}}" href="{{AppSubUrl}}/">{{.i18n.Tr "home"}}</a>
						<a class="item {{if .PageIsExplore}}active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.i18n.Tr "explore"}}</a>
					{{else if .IsLandingPageExplore}}
						<a class="item {{if .PageIsExplore}}active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.i18n.Tr "home"}}</a>
					{{else if .IsLandingPageOrganizations}}
						<a class="item {{if .PageIsExplore}}active{{end}}" href="{{AppSubUrl}}/explore/organizations">{{.i18n.Tr "home"}}</a>
					{{end}}

					{{template "custom/extra_links" .}}

					{{/*
						<div class="item">
						<div class="ui icon input">
						<input class="searchbox" type="text" placeholder="{{.i18n.Tr "search_project"}}">
						<i class="search icon"></i>
						</div>
						</div>
					*/}}

					{{if .IsSigned}}
						<div class="right stackable menu">
							<a href="{{AppSubUrl}}/notifications" class="item poping up" data-content='{{.i18n.Tr "notifications"}}' data-variation="tiny inverted">
								<span class="text">
									<i class="fitted octicon octicon-bell"></i>
									<span class="sr-mobile-only">{{.i18n.Tr "notifications"}}</span>

									{{if .NotificationUnreadCount}}
										<span class="ui red label">
											{{.NotificationUnreadCount}}
										</span>
									{{end}}
								</span>
							</a>

							<div class="ui dropdown jump item poping up" data-content="{{.i18n.Tr "create_new"}}" data-variation="tiny inverted">
								<span class="text">
									<i class="fitted octicon octicon-plus"></i>
									<span class="sr-mobile-only">{{.i18n.Tr "create_new"}}</span>
									<i class="fitted octicon octicon-triangle-down not-mobile"></i>
								</span>
								<div class="menu">
									<a class="item" href="{{AppSubUrl}}/repo/create">
										<i class="fitted octicon octicon-plus"></i> {{.i18n.Tr "new_repo"}}
									</a>
									<a class="item" href="{{AppSubUrl}}/repo/migrate">
										<i class="fitted octicon octicon-repo-clone"></i> {{.i18n.Tr "new_migrate"}}
									</a>
									{{if .SignedUser.CanCreateOrganization}}
									<a class="item" href="{{AppSubUrl}}/org/create">
										<i class="fitted octicon octicon-organization"></i> {{.i18n.Tr "new_org"}}
									</a>
									{{end}}
								</div><!-- end content create new menu -->
							</div><!-- end dropdown menu create new -->

							<div class="ui dropdown jump item poping up" tabindex="-1" data-content="{{.i18n.Tr "user_profile_and_more"}}" data-variation="tiny inverted">
								<span class="text">
									<img class="ui tiny avatar image" src="{{.SignedUser.RelAvatarLink}}">
									<span class="sr-only">{{.i18n.Tr "user_profile_and_more"}}</span>
									<span class="mobile-only">{{.SignedUser.Name}}</span>
									<i class="fitted octicon octicon-triangle-down not-mobile" tabindex="-1"></i>
								</span>
								<div class="menu" tabindex="-1">
									<div class="ui header">
										{{.i18n.Tr "signed_in_as"}} <strong>{{.SignedUser.Name}}</strong>
									</div>

									<div class="divider"></div>
									<a class="item" href="{{AppSubUrl}}/{{.SignedUser.Name}}">
										<i class="octicon octicon-person"></i>
										{{.i18n.Tr "your_profile"}}<!-- Your profile -->
									</a>
									<a class="item" href="{{AppSubUrl}}/{{.SignedUser.Name}}?tab=stars">
										<i class="octicon octicon-star"></i>
										{{.i18n.Tr "your_starred"}}
									</a>
									<a class="{{if .PageIsUserSettings}}active{{end}} item" href="{{AppSubUrl}}/user/settings">
										<i class="octicon octicon-settings"></i>
										{{.i18n.Tr "your_settings"}}<!-- Your settings -->
									</a>
									<a class="item" target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io">
										<i class="octicon octicon-question"></i>
										{{.i18n.Tr "help"}}<!-- Help -->
									</a>
									{{if .IsAdmin}}
										<div class="divider"></div>

										<a class="{{if .PageIsAdmin}}active{{end}} item" href="{{AppSubUrl}}/admin">
											<i class="icon settings"></i>
											{{.i18n.Tr "admin_panel"}}<!-- Admin Panel -->
										</a>
									{{end}}

									<div class="divider"></div>
									<a class="item" href="{{AppSubUrl}}/user/logout">
										<i class="octicon octicon-sign-out"></i>
										{{.i18n.Tr "sign_out"}}<!-- Sign Out -->
									</a>
								</div><!-- end content avatar menu -->
							</div><!-- end dropdown avatar menu -->
						</div><!-- end signed user right menu -->

					{{else}}

						<a class="item" target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io">{{.i18n.Tr "help"}}</a>
						<div class="right stackable menu">
							{{if .ShowRegistrationButton}}
								<a class="item{{if .PageIsSignUp}} active{{end}}" href="{{AppSubUrl}}/user/sign_up">
									<i class="octicon octicon-person"></i> {{.i18n.Tr "register"}}
								</a>
							{{end}}
							<a class="item{{if .PageIsSignIn}} active{{end}}" href="{{AppSubUrl}}/user/login?redirect_to={{.Link}}">
								<i class="octicon octicon-sign-in"></i> {{.i18n.Tr "sign_in"}}
							</a>
						</div><!-- end anonymous right menu -->

					{{end}}
				</div><!-- end container -->
			</div><!-- end bar -->
		{{end}}
{{/*
	</div>
</body>
</html>
*/}}
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-23 15:34:04 +0000