summaryrefslogtreecommitdiffstats
path: root/routers/api/packages/composer
diff options
context:
space:
mode:
authorKN4CK3R <admin@oldschoolhack.me>2022-12-31 12:49:37 +0100
committerGitHub <noreply@github.com>2022-12-31 12:49:37 +0100
commit3fef47b41c98392865d13fd21bbcec34236daf4f (patch)
tree16808c6ea9ffd2cc0438d11831fd3a7503d15056 /routers/api/packages/composer
parentdce8887494268c99ba5da8d5152b5d1cc03cfb83 (diff)
downloadgitea-3fef47b41c98392865d13fd21bbcec34236daf4f.tar.gz
gitea-3fef47b41c98392865d13fd21bbcec34236daf4f.zip
Use ErrInvalidArgument in packages (#22268)
Related to https://github.com/go-gitea/gitea/pull/22262#discussion_r1059010774 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
Diffstat (limited to 'routers/api/packages/composer')
-rw-r--r--routers/api/packages/composer/composer.go7
1 files changed, 6 insertions, 1 deletions
diff --git a/routers/api/packages/composer/composer.go b/routers/api/packages/composer/composer.go
index 58571fff14..a623952aa7 100644
--- a/routers/api/packages/composer/composer.go
+++ b/routers/api/packages/composer/composer.go
@@ -4,6 +4,7 @@
package composer
import (
+ "errors"
"fmt"
"io"
"net/http"
@@ -200,7 +201,11 @@ func UploadPackage(ctx *context.Context) {
cp, err := composer_module.ParsePackage(buf, buf.Size())
if err != nil {
- apiError(ctx, http.StatusBadRequest, err)
+ if errors.Is(err, util.ErrInvalidArgument) {
+ apiError(ctx, http.StatusBadRequest, err)
+ } else {
+ apiError(ctx, http.StatusInternalServerError, err)
+ }
return
}