aboutsummaryrefslogtreecommitdiffstats
path: root/routers/api/v1/admin
diff options
context:
space:
mode:
authorEarl Warren <109468362+earl-warren@users.noreply.github.com>2024-02-23 01:57:24 +0100
committerGitHub <noreply@github.com>2024-02-23 00:57:24 +0000
commitb748d62b461f9f23823f8772bc708b44b15a23a7 (patch)
tree3b4f437b1cb5096e09f77b8ad62b9788e9c77043 /routers/api/v1/admin
parent532e422027c88a4a3dc0c2968857f8d5f94d861f (diff)
downloadgitea-b748d62b461f9f23823f8772bc708b44b15a23a7.tar.gz
gitea-b748d62b461f9f23823f8772bc708b44b15a23a7.zip
Add slow SQL query warning (#27545)
- Databases are one of the most important parts of Forgejo, every interaction uses the database in one way or another. Therefore, it is important to maintain the database and recognize when the server is not doing well with the database. There already is the option to log *every* SQL query along with its execution time, but monitoring becomes impractical for larger instances and takes up unnecessary storage in the logs. - Add a QoL enhancement that allows instance administrators to specify a threshold value beyond which query execution time is logged as a warning in the xorm logger. The default value is a conservative five seconds to avoid this becoming a source of spam in the logs. - The use case for this patch is that with an instance the size of Codeberg, monitoring SQL logs is not very fruitful and most of them are uninteresting. Recently, in the context of persistent deadlock issues (https://codeberg.org/forgejo/forgejo/issues/220), I have noticed that certain queries hold locks on tables like comment and issue for several seconds. This patch helps to identify which queries these are and when they happen. - Added unit test. (cherry picked from commit 9cf501f1af4cd870221cef6af489618785b71186) --------- Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: 6543 <6543@obermui.de>
Diffstat (limited to 'routers/api/v1/admin')
0 files changed, 0 insertions, 0 deletions