diff options
| author | 6543 <6543@obermui.de> | 2021-07-13 09:14:14 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-13 08:14:14 +0100 |
| commit | b81106be3faadf7821c30b18fb1cec6c27041896 (patch) | |
| tree | 4e6198ec7013999bf8c85d79a00c4c14ea55c07a /routers/api/v1/repo/git_ref.go | |
| parent | 4ce32c9e93591f2449a388201c323ca193f59c07 (diff) | |
| download | gitea-b81106be3faadf7821c30b18fb1cec6c27041896.tar.gz gitea-b81106be3faadf7821c30b18fb1cec6c27041896.zip | |
Let branch/tag name be a valid ref to get CI status (#16400)
* fix #16384#
* refactor: move shared helper func to utils package
* extend Tests
* use ctx.Repo.GitRepo if not nil
Diffstat (limited to 'routers/api/v1/repo/git_ref.go')
| -rw-r--r-- | routers/api/v1/repo/git_ref.go | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/routers/api/v1/repo/git_ref.go b/routers/api/v1/repo/git_ref.go index bd43ad4fc8..e304e06740 100644 --- a/routers/api/v1/repo/git_ref.go +++ b/routers/api/v1/repo/git_ref.go @@ -8,8 +8,8 @@ import ( "net/http" "code.gitea.io/gitea/modules/context" - "code.gitea.io/gitea/modules/git" api "code.gitea.io/gitea/modules/structs" + "code.gitea.io/gitea/routers/api/v1/utils" ) // GetGitAllRefs get ref or an list all the refs of a repository @@ -73,22 +73,8 @@ func GetGitRefs(ctx *context.APIContext) { getGitRefsInternal(ctx, ctx.Params("*")) } -func getGitRefs(ctx *context.APIContext, filter string) ([]*git.Reference, string, error) { - gitRepo, err := git.OpenRepository(ctx.Repo.Repository.RepoPath()) - if err != nil { - return nil, "OpenRepository", err - } - defer gitRepo.Close() - - if len(filter) > 0 { - filter = "refs/" + filter - } - refs, err := gitRepo.GetRefsFiltered(filter) - return refs, "GetRefsFiltered", err -} - func getGitRefsInternal(ctx *context.APIContext, filter string) { - refs, lastMethodName, err := getGitRefs(ctx, filter) + refs, lastMethodName, err := utils.GetGitRefs(ctx, filter) if err != nil { ctx.Error(http.StatusInternalServerError, lastMethodName, err) return |