diff options
| author | zeripath <art27@cantab.net> | 2019-02-04 00:56:18 +0000 |
|---|---|---|
| committer | techknowlogick <matti@mdranta.net> | 2019-02-03 19:56:18 -0500 |
| commit | 24a36e84cc8f582ea7cd0d312777e083cd24e279 (patch) | |
| tree | 632869756cd420833b9c28fe664bf0da7b3370c1 /routers/api/v1/repo | |
| parent | 01c10a951b9db0b9f020ef657ca71eb5e5882a84 (diff) | |
| download | gitea-24a36e84cc8f582ea7cd0d312777e083cd24e279.tar.gz gitea-24a36e84cc8f582ea7cd0d312777e083cd24e279.zip | |
Issue 5924 fix compare button (#5929)
* Revert #5877
This unfortunately was not the solution.
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Change permission check to create pull requests to CanReadIssuesOrPulls
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'routers/api/v1/repo')
| -rw-r--r-- | routers/api/v1/repo/pull.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go index 2ad321ea38..64c7e94474 100644 --- a/routers/api/v1/repo/pull.go +++ b/routers/api/v1/repo/pull.go @@ -668,8 +668,8 @@ func parseCompareInfo(ctx *context.APIContext, form api.CreatePullRequestOption) ctx.ServerError("GetUserRepoPermission", err) return nil, nil, nil, nil, "", "" } - if !perm.CanWrite(models.UnitTypeCode) { - log.Trace("ParseCompareInfo[%d]: does not have write access or site admin", baseRepo.ID) + if !perm.CanReadIssuesOrPulls(true) { + log.Trace("ParseCompareInfo[%d]: cannot create/read pull requests", baseRepo.ID) ctx.Status(404) return nil, nil, nil, nil, "", "" } |