diff options
| author | Zettat123 <zettat123@gmail.com> | 2023-03-14 05:55:30 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-13 16:55:30 -0500 |
| commit | 8421b8264fd7715ec93b13f37be31a945faec556 (patch) | |
| tree | 891fd65121a7361480078c161970a2b597687842 /routers/api/v1 | |
| parent | 5eea61dbc8f8e82e0dd05addf76751ee517459a0 (diff) | |
| download | gitea-8421b8264fd7715ec93b13f37be31a945faec556.tar.gz gitea-8421b8264fd7715ec93b13f37be31a945faec556.zip | |
Handle missing `README` in create repos API (#23387)
Close #22934
In `/user/repos` API (and other APIs related to creating repos), user
can specify a readme template for auto init. At present, if the
specified template does not exist, a `500` will be returned . This PR
improved the logic and will return a `400` instead of `500`.
Diffstat (limited to 'routers/api/v1')
| -rw-r--r-- | routers/api/v1/admin/repo.go | 2 | ||||
| -rw-r--r-- | routers/api/v1/repo/repo.go | 11 |
2 files changed, 13 insertions, 0 deletions
diff --git a/routers/api/v1/admin/repo.go b/routers/api/v1/admin/repo.go index 83ed06e49b..a4895f260b 100644 --- a/routers/api/v1/admin/repo.go +++ b/routers/api/v1/admin/repo.go @@ -32,6 +32,8 @@ func CreateRepo(ctx *context.APIContext) { // responses: // "201": // "$ref": "#/responses/Repository" + // "400": + // "$ref": "#/responses/error" // "403": // "$ref": "#/responses/forbidden" // "404": diff --git a/routers/api/v1/repo/repo.go b/routers/api/v1/repo/repo.go index 397600dc50..16608e5bbb 100644 --- a/routers/api/v1/repo/repo.go +++ b/routers/api/v1/repo/repo.go @@ -231,6 +231,13 @@ func CreateUserRepo(ctx *context.APIContext, owner *user_model.User, opt api.Cre if opt.AutoInit && opt.Readme == "" { opt.Readme = "Default" } + + // If the readme template does not exist, a 400 will be returned. + if opt.AutoInit && len(opt.Readme) > 0 && !util.SliceContains(repo_module.Readmes, opt.Readme) { + ctx.Error(http.StatusBadRequest, "", fmt.Errorf("readme template does not exist, available templates: %v", repo_module.Readmes)) + return + } + repo, err := repo_service.CreateRepository(ctx, ctx.Doer, owner, repo_module.CreateRepoOptions{ Name: opt.Name, Description: opt.Description, @@ -283,6 +290,8 @@ func Create(ctx *context.APIContext) { // responses: // "201": // "$ref": "#/responses/Repository" + // "400": + // "$ref": "#/responses/error" // "409": // description: The repository with the same name already exists. // "422": @@ -464,6 +473,8 @@ func CreateOrgRepo(ctx *context.APIContext) { // responses: // "201": // "$ref": "#/responses/Repository" + // "400": + // "$ref": "#/responses/error" // "404": // "$ref": "#/responses/notFound" // "403": |