diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2024-03-12 15:23:44 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-12 07:23:44 +0000 |
| commit | d8bd6f34f09bc9a6602bebb33bdc9e1f255a0d7c (patch) | |
| tree | 1536b715fb816410535893e7ba10279d89119638 /routers/api | |
| parent | aed3b53abdd02a3ffbf9e8eb90272ff567333073 (diff) | |
| download | gitea-d8bd6f34f09bc9a6602bebb33bdc9e1f255a0d7c.tar.gz gitea-d8bd6f34f09bc9a6602bebb33bdc9e1f255a0d7c.zip | |
Do some performance optimize for issues list and view issue/pull (#29515)
This PR do some performance optimzations.
- [x] Add `index` for the column `comment_id` of `Attachment` table to
accelerate query from the database.
- [x] Remove unnecessary database queries when viewing issues. Before
some conditions which id = 0 will be sent to the database
- [x] Remove duplicated load posters
- [x] Batch loading attachements, isread of comments on viewing issue
---------
Co-authored-by: Zettat123 <zettat123@gmail.com>
Diffstat (limited to 'routers/api')
| -rw-r--r-- | routers/api/v1/repo/issue_comment.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/routers/api/v1/repo/issue_comment.go b/routers/api/v1/repo/issue_comment.go index 21aabadf3d..070571ba62 100644 --- a/routers/api/v1/repo/issue_comment.go +++ b/routers/api/v1/repo/issue_comment.go @@ -323,10 +323,6 @@ func ListRepoIssueComments(ctx *context.APIContext) { ctx.Error(http.StatusInternalServerError, "LoadIssues", err) return } - if err := comments.LoadPosters(ctx); err != nil { - ctx.Error(http.StatusInternalServerError, "LoadPosters", err) - return - } if err := comments.LoadAttachments(ctx); err != nil { ctx.Error(http.StatusInternalServerError, "LoadAttachments", err) return |