diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2021-12-01 15:50:01 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-01 15:50:01 +0800 |
| commit | 042cac5fedeec8af53080b9666fe043072f3a6be (patch) | |
| tree | b13d57faa71ba8bc9f8b3d40f5be7e3735ac66a4 /routers/init.go | |
| parent | a3517d8668482b58cb80ba10a956fe4e27e1a429 (diff) | |
| download | gitea-042cac5fedeec8af53080b9666fe043072f3a6be.tar.gz gitea-042cac5fedeec8af53080b9666fe043072f3a6be.zip | |
Improve install code to avoid low-level mistakes. (#17779)
* Improve install code to avoid low-level mistakes.
If a user tries to do a re-install in a Gitea database, they gets a warning and double check.
When Gitea runs, it never create empty app.ini automatically.
Also some small (related) refactoring:
* Refactor db.InitEngine related logic make it more clean (especially for the install code)
* Move some i18n strings out from setting.go to make the setting.go can be easily maintained.
* Show errors in CLI code if an incorrect app.ini is used.
* APP_DATA_PATH is created when installing, and checked when starting (no empty directory is created any more).
Diffstat (limited to 'routers/init.go')
| -rw-r--r-- | routers/init.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/routers/init.go b/routers/init.go index 58c7384092..4cce7992db 100644 --- a/routers/init.go +++ b/routers/init.go @@ -95,9 +95,8 @@ func syncAppPathForGit(ctx context.Context) error { return nil } -// GlobalInit is for global configuration reload-able. -func GlobalInit(ctx context.Context) { - setting.NewContext() +// GlobalInitInstalled is for global installed configuration. +func GlobalInitInstalled(ctx context.Context) { if !setting.InstallLock { log.Fatal("Gitea is not installed") } |