diff options
| author | zeripath <art27@cantab.net> | 2020-02-27 19:20:55 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-27 16:20:55 -0300 |
| commit | 90919bb37e2bcc62440e393439825fe0e1e1f343 (patch) | |
| tree | 1e89ce6ec5a3c90399a1621e6d11dae2417c11ef /routers/private/hook.go | |
| parent | 858aebc2d8561803c4dc3f8a427ca82662ee96c7 (diff) | |
| download | gitea-90919bb37e2bcc62440e393439825fe0e1e1f343.tar.gz gitea-90919bb37e2bcc62440e393439825fe0e1e1f343.zip | |
Show Signer in commit lists and add basic trust (#10425)
* Show Signer in commit lists and add basic trust
Show the avatar of the signer in the commit list pages as we do not
enforce that the signer is an author or committer. This makes it
clearer who has signed the commit.
Also display commits signed by non-members differently from
members and in particular make it clear when a non-member signer
is different from the committer to help reduce the risk of
spoofing.
Signed-off-by: Andrew Thornton <art27@cantab.net>
* ensure orange text and background is available
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update gpg_key.go
* Update models/gpg_key.go
* Apply suggestions from code review
* Require team collaborators to have access to UnitTypeCode
* as per @6543
* fix position of sha as per @silverwind
* as per @guillep2k
Diffstat (limited to 'routers/private/hook.go')
| -rw-r--r-- | routers/private/hook.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/routers/private/hook.go b/routers/private/hook.go index 44e82ebe6c..1d8cb4b48e 100644 --- a/routers/private/hook.go +++ b/routers/private/hook.go @@ -90,10 +90,8 @@ func readAndVerifyCommit(sha string, repo *git.Repository, env []string) error { if err != nil { return err } - log.Info("have commit %s", commit.ID.String()) verification := models.ParseCommitWithSignature(commit) if !verification.Verified { - log.Info("unverified commit %s", commit.ID.String()) cancel() return &errUnverifiedCommit{ commit.ID.String(), |