diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /routers/private | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'routers/private')
| -rw-r--r-- | routers/private/hook_pre_receive.go | 2 | ||||
| -rw-r--r-- | routers/private/manager_process.go | 2 | ||||
| -rw-r--r-- | routers/private/serv.go | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/routers/private/hook_pre_receive.go b/routers/private/hook_pre_receive.go index cadfea782c..fb4c039d49 100644 --- a/routers/private/hook_pre_receive.go +++ b/routers/private/hook_pre_receive.go @@ -248,7 +248,7 @@ func preReceiveBranch(ctx *preReceiveContext, oldCommitID, newCommitID, refFullN } // 5. Check if the doer is allowed to push - canPush := false + var canPush bool if ctx.opts.DeployKeyID != 0 { canPush = !changedProtectedfiles && protectBranch.CanPush && (!protectBranch.EnableWhitelist || protectBranch.WhitelistDeployKeys) } else { diff --git a/routers/private/manager_process.go b/routers/private/manager_process.go index f8932d61fa..e12bbee18b 100644 --- a/routers/private/manager_process.go +++ b/routers/private/manager_process.go @@ -34,7 +34,7 @@ func Processes(ctx *context.PrivateContext) { var processes []*process_module.Process goroutineCount := int64(0) - processCount := 0 + var processCount int var err error if stacktraces { processes, processCount, goroutineCount, err = process_module.GetManager().ProcessStacktraces(flat, noSystem) diff --git a/routers/private/serv.go b/routers/private/serv.go index 803d51e9d9..ddb2e6aa8b 100644 --- a/routers/private/serv.go +++ b/routers/private/serv.go @@ -142,7 +142,7 @@ func ServCommand(ctx *context.PrivateContext) { if repo_model.IsErrRepoNotExist(err) { repoExist = false for _, verb := range ctx.FormStrings("verb") { - if "git-upload-pack" == verb { + if verb == "git-upload-pack" { // User is fetching/cloning a non-existent repository log.Warn("Failed authentication attempt (cannot find repository: %s/%s) from %s", results.OwnerName, results.RepoName, ctx.RemoteAddr()) ctx.JSON(http.StatusNotFound, private.ErrServCommand{ |