diff options
| author | zeripath <art27@cantab.net> | 2020-03-27 12:34:39 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-27 14:34:39 +0200 |
| commit | e6baa656f757fd1f2f6ba20c677e0c83422a8739 (patch) | |
| tree | b2a396f41e1b8a08b796084d169f202d593f7357 /routers/repo/blame.go | |
| parent | a3f90948d8fa4dd5c92e15cc10e86d2fec37f6e7 (diff) | |
| download | gitea-e6baa656f757fd1f2f6ba20c677e0c83422a8739.tar.gz gitea-e6baa656f757fd1f2f6ba20c677e0c83422a8739.zip | |
make avatar lookup occur at image request (#10540)
speed up page generation by making avatar lookup occur at the browser
not at page generation
* Protect against evil email address ".."
* hash the complete email address
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-Authored-By: Lauris BH <lauris@nix.lv>
Diffstat (limited to 'routers/repo/blame.go')
| -rw-r--r-- | routers/repo/blame.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/routers/repo/blame.go b/routers/repo/blame.go index f5a2a548e3..beed59ea97 100644 --- a/routers/repo/blame.go +++ b/routers/repo/blame.go @@ -230,7 +230,7 @@ func renderBlame(ctx *context.Context, blameParts []git.BlamePart, commitNames m } avatar = fmt.Sprintf(`<a href="%s/%s"><img class="ui avatar image" src="%s" title="%s" alt=""/></a>`, setting.AppSubURL, url.PathEscape(commit.User.Name), commit.User.RelAvatarLink(), html.EscapeString(authorName)) } else { - avatar = fmt.Sprintf(`<img class="ui avatar image" src="%s" title="%s"/>`, html.EscapeString(base.AvatarLink(commit.Author.Email)), html.EscapeString(commit.Author.Name)) + avatar = fmt.Sprintf(`<img class="ui avatar image" src="%s" title="%s"/>`, html.EscapeString(models.AvatarLink(commit.Author.Email)), html.EscapeString(commit.Author.Name)) } commitInfo.WriteString(fmt.Sprintf(`<div class="blame-info%s"><div class="blame-data"><div class="blame-avatar">%s</div><div class="blame-message"><a href="%s/commit/%s" title="%[5]s">%[5]s</a></div><div class="blame-time">%s</div></div></div>`, attr, avatar, repoLink, part.Sha, html.EscapeString(commit.CommitMessage), commitSince)) } else { |