diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2017-12-11 12:37:04 +0800 |
|---|---|---|
| committer | Lauris BH <lauris@nix.lv> | 2017-12-11 06:37:04 +0200 |
| commit | f2e20c81b66e6a937ecdb686f8d1011371433365 (patch) | |
| tree | 490e5af82aefdd25de5d90225b083ecb3ed11e5f /routers/repo | |
| parent | c082c3bce35d6d5d829a1e516b9bbf45b6d49bdc (diff) | |
| download | gitea-f2e20c81b66e6a937ecdb686f8d1011371433365.tar.gz gitea-f2e20c81b66e6a937ecdb686f8d1011371433365.zip | |
Refactor struct's time to remove unnecessary memory usage (#3142)
* refactor struct's time to remove unnecessary memory usage
* use AsTimePtr simple code
* fix tests
* fix time compare
* fix template on gpg
* use AddDuration instead of Add
Diffstat (limited to 'routers/repo')
| -rw-r--r-- | routers/repo/http.go | 3 | ||||
| -rw-r--r-- | routers/repo/issue.go | 12 | ||||
| -rw-r--r-- | routers/repo/setting.go | 3 |
3 files changed, 10 insertions, 8 deletions
diff --git a/routers/repo/http.go b/routers/repo/http.go index c5b45f9cc8..c1fdad5350 100644 --- a/routers/repo/http.go +++ b/routers/repo/http.go @@ -22,6 +22,7 @@ import ( "code.gitea.io/gitea/modules/context" "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" + "code.gitea.io/gitea/modules/util" ) // HTTP implmentation git smart HTTP protocol @@ -167,7 +168,7 @@ func HTTP(ctx *context.Context) { return } - token.Updated = time.Now() + token.UpdatedUnix = util.TimeStampNow() if err = models.UpdateAccessToken(token); err != nil { ctx.Handle(http.StatusInternalServerError, "UpdateAccessToken", err) } diff --git a/routers/repo/issue.go b/routers/repo/issue.go index 884a805180..ba68b49ad8 100644 --- a/routers/repo/issue.go +++ b/routers/repo/issue.go @@ -1138,10 +1138,10 @@ func NewMilestonePost(ctx *context.Context, form auth.CreateMilestoneForm) { } if err = models.NewMilestone(&models.Milestone{ - RepoID: ctx.Repo.Repository.ID, - Name: form.Title, - Content: form.Content, - Deadline: deadline, + RepoID: ctx.Repo.Repository.ID, + Name: form.Title, + Content: form.Content, + DeadlineUnix: util.TimeStamp(deadline.Unix()), }); err != nil { ctx.Handle(500, "NewMilestone", err) return @@ -1210,7 +1210,7 @@ func EditMilestonePost(ctx *context.Context, form auth.CreateMilestoneForm) { } m.Name = form.Title m.Content = form.Content - m.Deadline = deadline + m.DeadlineUnix = util.TimeStamp(deadline.Unix()) if err = models.UpdateMilestone(m); err != nil { ctx.Handle(500, "UpdateMilestone", err) return @@ -1243,7 +1243,7 @@ func ChangeMilestonStatus(ctx *context.Context) { ctx.Redirect(ctx.Repo.RepoLink + "/milestones?state=open") case "close": if !m.IsClosed { - m.ClosedDate = time.Now() + m.ClosedDateUnix = util.TimeStampNow() if err = models.ChangeMilestoneStatus(m, true); err != nil { ctx.Handle(500, "ChangeMilestoneStatus", err) return diff --git a/routers/repo/setting.go b/routers/repo/setting.go index 16cc699ae2..329802673d 100644 --- a/routers/repo/setting.go +++ b/routers/repo/setting.go @@ -16,6 +16,7 @@ import ( "code.gitea.io/gitea/modules/context" "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" + "code.gitea.io/gitea/modules/util" "code.gitea.io/gitea/routers/utils" ) @@ -119,7 +120,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) { } else { ctx.Repo.Mirror.EnablePrune = form.EnablePrune ctx.Repo.Mirror.Interval = interval - ctx.Repo.Mirror.NextUpdate = time.Now().Add(interval) + ctx.Repo.Mirror.NextUpdateUnix = util.TimeStampNow().AddDuration(interval) if err := models.UpdateMirror(ctx.Repo.Mirror); err != nil { ctx.RenderWithErr(ctx.Tr("repo.mirror_interval_invalid"), tplSettingsOptions, &form) return |