diff options
| author | zeripath <art27@cantab.net> | 2021-08-11 21:42:58 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-11 21:42:58 +0100 |
| commit | e29e1637370ad95e4ca9f861c25d366b74829dcc (patch) | |
| tree | 63c0b53fa958b23fdf1f3e5216df250a24016706 /routers/web/admin | |
| parent | f1a810e0901b80eb6bc21103434fc0737af17eaa (diff) | |
| download | gitea-e29e1637370ad95e4ca9f861c25d366b74829dcc.tar.gz gitea-e29e1637370ad95e4ca9f861c25d366b74829dcc.zip | |
Improve SMTP authentication and Fix user creation bugs (#16612)
* Improve SMTP authentication, Fix user creation bugs and add LDAP cert/key options
This PR has two parts:
Improvements for SMTP authentication:
* Default to use SMTPS if port is 465, and allow setting of force SMTPS.
* Always use STARTTLS if available
* Provide CRAM-MD5 mechanism
* Add options for HELO hostname disabling
* Add options for providing certificates and keys
* Handle application specific password response as a failed user login
instead of as a 500.
Close #16104
Fix creation of new users:
* A bug was introduced when allowing users to change usernames which
prevents the creation of external users.
* The LoginSource refactor also broke this page.
Close #16104
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'routers/web/admin')
| -rw-r--r-- | routers/web/admin/auths.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/routers/web/admin/auths.go b/routers/web/admin/auths.go index 2e9697533a..342318e04e 100644 --- a/routers/web/admin/auths.go +++ b/routers/web/admin/auths.go @@ -154,8 +154,10 @@ func parseSMTPConfig(form forms.AuthenticationForm) *smtp.Source { Host: form.SMTPHost, Port: form.SMTPPort, AllowedDomains: form.AllowedDomains, - TLS: form.TLS, + ForceSMTPS: form.ForceSMTPS, SkipVerify: form.SkipVerify, + HeloHostname: form.HeloHostname, + DisableHelo: form.DisableHelo, } } |